From 332789a87aa36a8d1dc42de542ef80f55645aad5 Mon Sep 17 00:00:00 2001 From: mDuo13 Date: Tue, 28 Jan 2025 13:50:07 -0800 Subject: [PATCH 1/3] Fix minor issues with Code Samples - The description gets deleted if it matches the title exactly (due to how our plugin finds the text of the README). Changed a couple instances to not match exactly so this doesn't happen. - Changed the top level of the Code Sampels layout to be a
element, which allows some styles to apply correctly and also helps the search crawler find the contents of the page. --- _code-samples/did/README.md | 2 +- _code-samples/price_oracles/README.md | 2 +- resources/code-samples.page.tsx | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/_code-samples/did/README.md b/_code-samples/did/README.md index 46913bd09d..b5f62cc239 100644 --- a/_code-samples/did/README.md +++ b/_code-samples/did/README.md @@ -1,3 +1,3 @@ # Create, Update, and Delete Decentralized Identifiers (DIDs) -Create, Update, and Delete Decentralized Identifiers (DIDs). A Decentralized Identifier (DID) is a new type of identifier defined by the World Wide Web Consortium (W3C) that enables verifiable, digital identities. +Create, update, and delete decentralized identifiers (DIDs). A Decentralized Identifier (DID) is a new type of identifier defined by the World Wide Web Consortium (W3C) that enables verifiable, digital identities. diff --git a/_code-samples/price_oracles/README.md b/_code-samples/price_oracles/README.md index fb2dcf37dc..e075240cc5 100644 --- a/_code-samples/price_oracles/README.md +++ b/_code-samples/price_oracles/README.md @@ -1,3 +1,3 @@ # Create, Update, and Delete Price Oracles -Create, Update, and Delete Price Oracles. A price oracle is a mechanism that feeds external data, such as asset prices, and exchange rates, onto the XRPLedger. +Create, update, and delete Price Oracles. A price oracle is a mechanism that feeds external data, such as asset prices, and exchange rates, onto the XRPLedger. diff --git a/resources/code-samples.page.tsx b/resources/code-samples.page.tsx index 2375d1b9f4..c578ec1250 100644 --- a/resources/code-samples.page.tsx +++ b/resources/code-samples.page.tsx @@ -29,7 +29,7 @@ export default function CodeSamples() { const { codeSamples, langs } = usePageSharedData('code-samples'); return ( -
+
@@ -126,6 +126,6 @@ export default function CodeSamples() {
-
+
); } From e1ec0d7e7c1a935efcc95dd926f5f4cc1496c40a Mon Sep 17 00:00:00 2001 From: mDuo13 Date: Fri, 31 Jan 2025 15:13:37 -0800 Subject: [PATCH 2/3] Further fix code samples descriptions --- @theme/plugins/code-samples.js | 2 +- _code-samples/build-a-browser-wallet/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/@theme/plugins/code-samples.js b/@theme/plugins/code-samples.js index 53b66f2fe8..27ba4fbd5a 100644 --- a/@theme/plugins/code-samples.js +++ b/@theme/plugins/code-samples.js @@ -28,7 +28,7 @@ export function codeSamples() { samples.push({ path: dirPath, title: title || toTitleCase(dirname(dirPath)), - description: getInnerText([data.ast.children[1]]).replace(title, '').trim(), + description: getInnerText([data.ast.children[1]]).trim(), href: joinPath('content', dirPath), langs, }); diff --git a/_code-samples/build-a-browser-wallet/README.md b/_code-samples/build-a-browser-wallet/README.md index 640e29134a..ac2be2a3e5 100644 --- a/_code-samples/build-a-browser-wallet/README.md +++ b/_code-samples/build-a-browser-wallet/README.md @@ -1,3 +1,3 @@ # Build a Browser Wallet -Implement a non-custodial wallet application that runs on in a web browser and can check an account's balances, send XRP, and notify when the account receives incoming transactions. +Implement a non-custodial wallet application that runs in a web browser and can check an account's balances, send XRP, and notify when the account receives incoming transactions. From 8d9e09e772646188c3f38ae357cb95a47e76fcd9 Mon Sep 17 00:00:00 2001 From: Maria Shodunke Date: Tue, 4 Feb 2025 13:32:44 +0000 Subject: [PATCH 3/3] 1838 - Add limit response field in account_lines --- .../public-api-methods/account-methods/account_lines.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/references/http-websocket-apis/public-api-methods/account-methods/account_lines.md b/docs/references/http-websocket-apis/public-api-methods/account-methods/account_lines.md index 7ff0f3d928..9aab9333f4 100644 --- a/docs/references/http-websocket-apis/public-api-methods/account-methods/account_lines.md +++ b/docs/references/http-websocket-apis/public-api-methods/account-methods/account_lines.md @@ -419,6 +419,7 @@ The response follows the [standard format][], with a successful result containin | `ledger_index` | Integer - [Ledger Index][] | _(Omitted if `ledger_current_index` provided instead)_ The ledger index of the ledger version that was used when retrieving this data. | | `ledger_hash` | String - [Hash][] | _(May be omitted)_ The identifying hash the ledger version that was used when retrieving this data. | | `marker` | [Marker][] | Server-defined value indicating the response is paginated. Pass this to the next call to resume where this call left off. Omitted when there are no additional pages after this one. | +|`limit` | Unsigned Integer | The maximum number of trust lines retrieved. The server may return fewer than the specified limit, even if more results are available. If no limit was specified in the request, this defaults to 200. | Each trust line object has some combination of the following fields: @@ -427,8 +428,8 @@ Each trust line object has some combination of the following fields: | `account` | String | The unique [Address][] of the counterparty to this trust line. | | `balance` | String | Representation of the numeric balance currently held against this line. A positive balance means that the perspective account holds value; a negative balance means that the perspective account owes value. | | `currency` | String | A [Currency Code][] identifying what currency this trust line can hold. | -| `limit` | String | The maximum amount of the given currency that this account is willing to owe the peer account | -| `limit_peer` | String | The maximum amount of currency that the counterparty account is willing to owe the perspective account | +| `limit` | String | The maximum amount of the given currency that this account is willing to owe the peer account. | +| `limit_peer` | String | The maximum amount of currency that the counterparty account is willing to owe the perspective account. | | `quality_in` | Unsigned Integer | Rate at which the account values incoming balances on this trust line, as a ratio of this value per 1 billion units. (For example, a value of 500 million represents a 0.5:1 ratio.) As a special case, 0 is treated as a 1:1 ratio. | | `quality_out` | Unsigned Integer | Rate at which the account values outgoing balances on this trust line, as a ratio of this value per 1 billion units. (For example, a value of 500 million represents a 0.5:1 ratio.) As a special case, 0 is treated as a 1:1 ratio. | | `no_ripple` | Boolean | _(May be omitted)_ If `true`, this account has enabled the [No Ripple flag](../../../../concepts/tokens/fungible-tokens/rippling.md) for this trust line. If present and `false`, this account has disabled the No Ripple flag, but, because the account also has the Default Ripple flag disabled, that is not considered [the default state](../../../protocol/ledger-data/ledger-entry-types/ripplestate.md#contributing-to-the-owner-reserve). If omitted, the account has the No Ripple flag disabled for this trust line and Default Ripple enabled. {% badge href="https://github.com/XRPLF/rippled/releases/tag/1.7.0" %}Updated in: rippled 1.7.0{% /badge %} |