From ecefcb4d3440f920f1ddbb4374b500979ebdff48 Mon Sep 17 00:00:00 2001 From: zgrguric Date: Sun, 21 Apr 2024 11:47:34 +0200 Subject: [PATCH 1/2] AMMBid explain non-trading fee case Adds single sentence which addresses case when user bids on Pool which has not Trading fee yet set. For reference this is the transaction on XRPL Mainnet: A3A278DEEF3C5E06126526F948F31436BDDD96E61779E2E7A55090270017BD89 --- docs/references/protocol/transactions/types/ammbid.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/references/protocol/transactions/types/ammbid.md b/docs/references/protocol/transactions/types/ammbid.md index 8ea80d5fc3..9ca1abf8c8 100644 --- a/docs/references/protocol/transactions/types/ammbid.md +++ b/docs/references/protocol/transactions/types/ammbid.md @@ -11,7 +11,7 @@ labels: _(Requires the [AMM amendment][])_ -Bid on an [Automated Market Maker](../../../../concepts/tokens/decentralized-exchange/automated-market-makers.md)'s (AMM's) auction slot. If you win, you can trade against the AMM at a discounted fee until you are outbid or 24 hours have passed. If you are outbid before 24 hours have passed, you are refunded part of the cost of your bid based on how much time remains. +Bid on an [Automated Market Maker](../../../../concepts/tokens/decentralized-exchange/automated-market-makers.md)'s (AMM's) auction slot. If you win, you can trade against the AMM at a discounted fee until you are outbid or 24 hours have passed. If you are outbid before 24 hours have passed, you are refunded part of the cost of your bid based on how much time remains. A Bid on AMM pool without trading fee set may result in sucessful transaction but will have no effect. You bid using the AMM's LP Tokens; the amount of a winning bid is returned to the AMM, decreasing the outstanding balance of LP Tokens. From 4f1850b02a071088df84ed40f68ab6b5eb5216ed Mon Sep 17 00:00:00 2001 From: Rome Reginelli Date: Wed, 5 Jun 2024 10:54:24 -0700 Subject: [PATCH 2/2] Rephrase AMMBid zero-fee case --- docs/references/protocol/transactions/types/ammbid.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/references/protocol/transactions/types/ammbid.md b/docs/references/protocol/transactions/types/ammbid.md index 9ca1abf8c8..35f9f6d5a2 100644 --- a/docs/references/protocol/transactions/types/ammbid.md +++ b/docs/references/protocol/transactions/types/ammbid.md @@ -11,7 +11,7 @@ labels: _(Requires the [AMM amendment][])_ -Bid on an [Automated Market Maker](../../../../concepts/tokens/decentralized-exchange/automated-market-makers.md)'s (AMM's) auction slot. If you win, you can trade against the AMM at a discounted fee until you are outbid or 24 hours have passed. If you are outbid before 24 hours have passed, you are refunded part of the cost of your bid based on how much time remains. A Bid on AMM pool without trading fee set may result in sucessful transaction but will have no effect. +Bid on an [Automated Market Maker](../../../../concepts/tokens/decentralized-exchange/automated-market-makers.md)'s (AMM's) auction slot. If you win, you can trade against the AMM at a discounted fee until you are outbid or 24 hours have passed. If you are outbid before 24 hours have passed, you are refunded part of the cost of your bid based on how much time remains. If the AMM's trading fee is zero, you can still bid, but the auction slot provides no benefit unless the trading fee changes. You bid using the AMM's LP Tokens; the amount of a winning bid is returned to the AMM, decreasing the outstanding balance of LP Tokens.