From 4103095b39d2d0abafc0cbe80065e87f8043027f Mon Sep 17 00:00:00 2001 From: Rome Reginelli Date: Tue, 5 Aug 2025 10:43:48 -0700 Subject: [PATCH] Apply suggestions from @oeggert review Co-authored-by: oeggert <117319296+oeggert@users.noreply.github.com> --- _code-samples/delegate-permissions/js/README.md | 6 +++--- .../delegate-permissions/js/delegate-permissions.js | 2 +- docs/references/protocol/data-types/permission-values.md | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/_code-samples/delegate-permissions/js/README.md b/_code-samples/delegate-permissions/js/README.md index f8e2ea47e6..4259d88f46 100644 --- a/_code-samples/delegate-permissions/js/README.md +++ b/_code-samples/delegate-permissions/js/README.md @@ -4,7 +4,7 @@ These code samples demonstrate how to delegate permissions to another account an ## Usage -1. First, install dependencies. +1. Install dependencies. ```sh npm i @@ -26,9 +26,9 @@ These code samples demonstrate how to delegate permissions to another account an If it runs successfully, it should output several things including "Delegate successfully set." followed by an [account_objects API method](https://xrpl.org/docs/references/http-websocket-apis/public-api-methods/account-methods/account_objects) response showing the delegate permissions. - Take note of the `account` address in this output. That's the address of the delegating account. + Take note of the `account` address in this output. That's the address of the delegator. -5. Run `use-delegate-permissions.js` and provide both the delegating account's address (from the previous step's output) and the delegate's secret key (from the devnet faucet earlier). +5. Run `use-delegate-permissions.js` and provide both the delegator's address (from the previous step's output) and the delegate's secret key (from the devnet faucet earlier). If it runs successfully, it should output various things ending in the following: diff --git a/_code-samples/delegate-permissions/js/delegate-permissions.js b/_code-samples/delegate-permissions/js/delegate-permissions.js index e227f967af..bf4ea1d155 100644 --- a/_code-samples/delegate-permissions/js/delegate-permissions.js +++ b/_code-samples/delegate-permissions/js/delegate-permissions.js @@ -11,7 +11,7 @@ async function main() { const delegate_address = "r9GAKojMTyexqvy8DXFWYq63Mod5k5wnkT" const delegateset = { "TransactionType": "DelegateSet", - "Account": wallet.address, + "Account": wallet.address, // Delegator address "Authorize": delegate_address, "Permissions": [ { diff --git a/docs/references/protocol/data-types/permission-values.md b/docs/references/protocol/data-types/permission-values.md index ead5980292..02b5306ea1 100644 --- a/docs/references/protocol/data-types/permission-values.md +++ b/docs/references/protocol/data-types/permission-values.md @@ -36,7 +36,7 @@ For a mapping of transaction types known by a server and their corresponding num ### List of Non-Delegatable Permissions -Some transaction types are not delegatable. If you attempt to grant these permissions to a delegate, the transaction fails with a [result code](../transactions/transaction-results/) such as `tecNO_PERMISSION`. This includes all transaction types that can be used to grant other permissions to different key pairs or accounts. Additionally, all [pseudo-transaction types](/docs/references/protocol/transactions/pseudo-transaction-types/pseudo-transaction-types) are not delegatable since they are not meant to be sent by normal accounts anyway. +Some transaction types can't be delegated. If you attempt to grant these permissions to a delegate, the transaction fails with a [result code](../transactions/transaction-results/) such as `tecNO_PERMISSION`. This includes all transaction types that can be used to grant other permissions to different key pairs or accounts. Additionally, all [pseudo-transaction types](/docs/references/protocol/transactions/pseudo-transaction-types/pseudo-transaction-types) can't be delegated since they can't be sent by normal accounts anyway. The following permissions cannot be delegated: