ARCHIVE/xrpl-dev-portal
1
0
Fork 0
mirror of https://github.com/XRPLF/xrpl-dev-portal.git synced 2025-11-20 19:55:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update with SME review comments

Browse Source
This commit is contained in:
Maria Shodunke
2025-04-17 11:07:19 +01:00
parent 0f9338c0b9
commit 2bcb9f67d3
6 changed files with 33 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
_code-samples/issue-credentials/js/issuer_service.js
View File

@@ -18,7 +18,7 @@ dotenv.config();
async function initWallet() {
let seed = process.env.ISSUER_ACCOUNT_SEED;
if (!seed) {
if (!seed || seed.startsWith("<")) {
const { seedInput } = await inquirer.prompt([
{
type: "password",
@@ -89,11 +89,11 @@ async function main() {
URI: credXrpl.uri,
Expiration: credXrpl.expiration,
};
const ccResponse = await client.submit(tx, { autofill: true, wallet });
const ccResponse = await client.submitAndWait(tx, { autofill: true, wallet });
if (ccResponse.result.engine_result === "tecDUPLICATE") {
if (ccResponse.result.meta.TransactionResult === "tecDUPLICATE") {
throw new XRPLTxError(ccResponse, 409);
} else if (ccResponse.result.engine_result !== "tesSUCCESS") {
} else if (ccResponse.result.meta.TransactionResult !== "tesSUCCESS") {
throw new XRPLTxError(ccResponse);
}
@@ -137,6 +137,7 @@ async function main() {
issuer: wallet.address,
credential_type: credential,
},
ledger_index: "validated",
});
const tx = {
@@ -146,12 +147,12 @@ async function main() {
CredentialType: credential,
};
const cdResponse = await client.submit(tx, { autofill: true, wallet });
if (cdResponse.result.engine_result === "tecNO_ENTRY") {
const cdResponse = await client.submitAndWait(tx, { autofill: true, wallet });
if (cdResponse.result.meta.TransactionResult === "tecNO_ENTRY") {
// Usually this won't happen since we just checked for the credential,
// but it's possible it got deleted since then.
throw new XRPLTxError(cdResponse, 404);
} else if (cdResponse.result.engine_result !== "tesSUCCESS") {
} else if (cdResponse.result.meta.TransactionResult !== "tesSUCCESS") {
throw new XRPLTxError(cdResponse);
}