ARCHIVE/xrpl-dev-portal
1
0
Fork 0
mirror of https://github.com/XRPLF/xrpl-dev-portal.git synced 2025-11-23 13:15:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix tx-serialization JS sample code

Browse Source
This commit is contained in:
mDuo13
2025-05-19 15:09:05 -07:00
parent f88f9d1cf0
commit 0bef4e48c9
4 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
_code-samples/tx-serialization/js/index.js
View File

@@ -37,7 +37,11 @@ const args = parseArgs(process.argv.slice(2), {
function _pretty(message, color) { function _pretty(message, color) {
if (!args.raw) { if (!args.raw) {
if (color) {
console.log(color,message) console.log(color,message)
} else {
console.log(message)
}
} }
} }

3
_code-samples/tx-serialization/js/package.json
View File

@@ -7,10 +7,9 @@
"big-integer": "^1.6.52", "big-integer": "^1.6.52",
"buffer": "^6.0.3", "buffer": "^6.0.3",
"decimal.js": "^10.4.3", "decimal.js": "^10.4.3",
"fs": "^0.0.1-security",
"minimist": "^1.2.7", "minimist": "^1.2.7",
"ripple-address-codec": "^5.0.0", "ripple-address-codec": "^5.0.0",
"xrpl": "^4.0.0" "xrpl": "^4.2.5"
}, },
"main": "index.js", "main": "index.js",
"scripts": { "scripts": {

4
_code-samples/tx-serialization/js/test-cases/README.md
View File

@@ -6,7 +6,7 @@ you can use to verify the behavior of the transaction serialization code.
For example (starting from the `tx-serialization/js/` dir above this one): For example (starting from the `tx-serialization/js/` dir above this one):
```bash ```bash
$ node index.js -f test-cases/tx2.json | \ $ node index.js -rf test-cases/tx2.json | \
diff - test-cases/tx2-binary.txt diff - test-cases/tx2-binary.txt
``` ```
@@ -46,7 +46,7 @@ CDC63E1DEE7FE3744630440220143759437C04F7B61F012563AFE90D8DAFC46E86035E1D965A9CED
For a friendlier display, you could pipe the output of the serializer to a file and use a visual tool like [Meld](http://meldmerge.org/) that shows intra-line differences: For a friendlier display, you could pipe the output of the serializer to a file and use a visual tool like [Meld](http://meldmerge.org/) that shows intra-line differences:
```bash ```bash
$ cat test-cases/tx1.json | sed -e 's/"Fee": "10"/"Fee": "100"/' | node index.js --stdin > /tmp/tx1-modified.txt && meld /tmp/tx1-modified.txt test-cases/tx1-binary.txt $ cat test-cases/tx1.json | sed -e 's/"Fee": "10"/"Fee": "100"/' | node index.js --raw --stdin > /tmp/tx1-modified.txt && meld /tmp/tx1-modified.txt test-cases/tx1-binary.txt
``` ```
![Meld screenshot showing the `0A` / `64` difference](meld-example.png) ![Meld screenshot showing the `0A` / `64` difference](meld-example.png)

5
_code-samples/tx-serialization/js/tx-serializer.js
View File

@@ -92,7 +92,7 @@ class TxSerializer {
_decodeAddress(address) { _decodeAddress(address) {
const decoded = codec.decodeChecked(address) const decoded = codec.decodeChecked(address)
if (decoded[0] === 0 && decoded.length === 21) { if (decoded[0] === 0 && decoded.length === 21) {
return decoded.slice(1) return Buffer.from(decoded.slice(1))
} }
throw new Error("Not an AccountID!") throw new Error("Not an AccountID!")
@@ -161,7 +161,7 @@ class TxSerializer {
const byte2 = this.uint8ToBytes(typeCode) const byte2 = this.uint8ToBytes(typeCode)
const byte3 = this.uint8ToBytes(fieldCode) const byte3 = this.uint8ToBytes(fieldCode)
return "" + byte1 + byte2 + byte3 //TODO: bytes is python function return "" + byte1 + byte2 + byte3
} }
} }
@@ -681,7 +681,6 @@ class TxSerializer {
fieldsAsBytes.push(fieldBytes) fieldsAsBytes.push(fieldBytes)
} }
} }
return fieldsAsBytes.join('') return fieldsAsBytes.join('')
} }
} }