mirror of
https://github.com/Xahau/xahaud.git
synced 2026-06-03 00:36:37 +00:00
1ce1079dda
Re-enable FullBelowCache in null-nodestore mode. Previously disabled via useFullBelowCache() returning false, forcing sync to walk every branch. That was a workaround for the stale-claim problem where an FBC entry could outlive the canonical node it vouches for, leading to SHAMapMissingNode on later reads. At the two FBC short-circuit sites (SHAMap::addKnownNode and gmn_ProcessNodes), null mode now: - validates the claim via TreeNodeCache::fetch (returns non-null iff the canonical node is held alive anywhere in the system), and - anchors the canonical into THIS SHAMap via canonicalizeChild, so retention is structural and independent of whichever ledger originally anchored the claim. Disk-backed mode is byte-identical to before (gated on isRWDBNullMode()). With the anchor rule in place, the post-sync wiring walks in InboundLedger::init() and done() are redundant; drop both and call setFullyWired() directly in null mode. Adds projected-source markers at key points for the design doc at .ai-docs/null-nodestore-backend.md.j2 (not tracked).
Basics
Utility functions and classes.
ripple/basic should contain no dependencies on other modules.
Choosing a rippled container.
-
std::vector- For ordered containers with most insertions or erases at the end.
-
std::deque- For ordered containers with most insertions or erases at the start or end.
-
std::list- For ordered containers with inserts and erases to the middle.
- For containers with iterators stable over insert and erase.
- Generally slower and bigger than
std::vectororstd::dequeexcept for those cases.
-
std::set- For sorted containers.
-
ripple::hash_set- Where inserts and contains need to be O(1).
- For "small" sets,
std::setmight be faster and smaller.
-
ripple::hardened_hash_set- For data sets where the key could be manipulated by an attacker in an attempt to mount an algorithmic complexity attack: see http://en.wikipedia.org/wiki/Algorithmic_complexity_attack
The following container is deprecated
std::unordered_set- Use
ripple::hash_setinstead, which uses a better hashing algorithm. - Or use
ripple::hardened_hash_setto prevent algorithmic complexity attacks.