mirror of
https://github.com/Xahau/xahaud.git
synced 2025-12-06 17:27:52 +00:00
44fe0e1fc4
Support for 'out-of-sequence' transaction execution was introduced
in commit 7724cca384.
The changes in that commit were gated under a feature but there was
no corresponding amendment introduced that would allow the network
to vote on this amendment.
This commit introduces 'TicketBatch' amendment as the amendment
that is associated with the tickets feature. If the amendment is
enabled, it will activate support for tickets.
This commit also removes several workarounds that are no longer
needed in unit tests.
269 lines
8.4 KiB
C++
269 lines
8.4 KiB
C++
//------------------------------------------------------------------------------
|
|
/*
|
|
This file is part of rippled: https://github.com/ripple/rippled
|
|
Copyright (c) 2016 Ripple Labs Inc.
|
|
|
|
Permission to use, copy, modify, and/or distribute this software for any
|
|
purpose with or without fee is hereby granted, provided that the above
|
|
copyright notice and this permission notice appear in all copies.
|
|
|
|
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
|
|
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
|
|
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
|
|
ANY SPECIAL , DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
|
|
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
|
|
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
|
|
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
|
|
*/
|
|
//==============================================================================
|
|
|
|
#include <ripple/protocol/Feature.h>
|
|
#include <ripple/protocol/jss.h>
|
|
#include <test/jtx.h>
|
|
|
|
namespace ripple {
|
|
|
|
class SetRegularKey_test : public beast::unit_test::suite
|
|
{
|
|
public:
|
|
void
|
|
testDisableMasterKey()
|
|
{
|
|
using namespace test::jtx;
|
|
|
|
testcase("Set regular key");
|
|
Env env{*this, supported_amendments() - fixMasterKeyAsRegularKey};
|
|
Account const alice("alice");
|
|
Account const bob("bob");
|
|
env.fund(XRP(10000), alice, bob);
|
|
|
|
env(regkey(alice, bob));
|
|
auto const ar = env.le(alice);
|
|
BEAST_EXPECT(
|
|
ar->isFieldPresent(sfRegularKey) &&
|
|
(ar->getAccountID(sfRegularKey) == bob.id()));
|
|
|
|
env(noop(alice), sig(bob));
|
|
env(noop(alice), sig(alice));
|
|
|
|
testcase("Disable master key");
|
|
env(fset(alice, asfDisableMaster), sig(alice));
|
|
env(noop(alice), sig(bob));
|
|
env(noop(alice), sig(alice), ter(tefMASTER_DISABLED));
|
|
|
|
testcase("Re-enable master key");
|
|
env(fclear(alice, asfDisableMaster),
|
|
sig(alice),
|
|
ter(tefMASTER_DISABLED));
|
|
|
|
env(fclear(alice, asfDisableMaster), sig(bob));
|
|
env(noop(alice), sig(bob));
|
|
env(noop(alice), sig(alice));
|
|
|
|
testcase("Revoke regular key");
|
|
env(regkey(alice, disabled));
|
|
env(noop(alice), sig(bob), ter(tefBAD_AUTH_MASTER));
|
|
env(noop(alice), sig(alice));
|
|
}
|
|
|
|
void
|
|
testDisableMasterKeyAfterFix()
|
|
{
|
|
using namespace test::jtx;
|
|
|
|
testcase("Set regular key");
|
|
Env env{*this, supported_amendments() | fixMasterKeyAsRegularKey};
|
|
Account const alice("alice");
|
|
Account const bob("bob");
|
|
env.fund(XRP(10000), alice, bob);
|
|
|
|
env(regkey(alice, bob));
|
|
env(noop(alice), sig(bob));
|
|
env(noop(alice), sig(alice));
|
|
|
|
testcase("Disable master key");
|
|
env(fset(alice, asfDisableMaster), sig(alice));
|
|
env(noop(alice), sig(bob));
|
|
env(noop(alice), sig(alice), ter(tefMASTER_DISABLED));
|
|
|
|
testcase("Re-enable master key");
|
|
env(fclear(alice, asfDisableMaster),
|
|
sig(alice),
|
|
ter(tefMASTER_DISABLED));
|
|
|
|
env(fclear(alice, asfDisableMaster), sig(bob));
|
|
env(noop(alice), sig(bob));
|
|
env(noop(alice), sig(alice));
|
|
|
|
testcase("Revoke regular key");
|
|
env(regkey(alice, disabled));
|
|
env(noop(alice), sig(bob), ter(tefBAD_AUTH));
|
|
env(noop(alice), sig(alice));
|
|
}
|
|
|
|
void
|
|
testDisabledRegularKey()
|
|
{
|
|
using namespace test::jtx;
|
|
|
|
// See https://ripplelabs.atlassian.net/browse/RIPD-1721.
|
|
testcase(
|
|
"Set regular key to master key (before fixMasterKeyAsRegularKey)");
|
|
Env env{*this, supported_amendments() - fixMasterKeyAsRegularKey};
|
|
Account const alice("alice");
|
|
env.fund(XRP(10000), alice);
|
|
|
|
// Must be possible unless amendment `fixMasterKeyAsRegularKey` enabled.
|
|
env(regkey(alice, alice), sig(alice));
|
|
env(fset(alice, asfDisableMaster), sig(alice));
|
|
|
|
// No way to sign...
|
|
env(noop(alice), ter(tefMASTER_DISABLED));
|
|
env(noop(alice), sig(alice), ter(tefMASTER_DISABLED));
|
|
|
|
// ... until now.
|
|
env.enableFeature(fixMasterKeyAsRegularKey);
|
|
env(noop(alice));
|
|
env(noop(alice), sig(alice));
|
|
|
|
env(regkey(alice, disabled), ter(tecNO_ALTERNATIVE_KEY));
|
|
env(fclear(alice, asfDisableMaster));
|
|
env(regkey(alice, disabled));
|
|
env(fset(alice, asfDisableMaster), ter(tecNO_ALTERNATIVE_KEY));
|
|
}
|
|
|
|
void
|
|
testDisableRegularKeyAfterFix()
|
|
{
|
|
using namespace test::jtx;
|
|
|
|
testcase(
|
|
"Set regular key to master key (after fixMasterKeyAsRegularKey)");
|
|
Env env{*this, supported_amendments() | fixMasterKeyAsRegularKey};
|
|
Account const alice("alice");
|
|
env.fund(XRP(10000), alice);
|
|
|
|
// Must be possible unless amendment `fixMasterKeyAsRegularKey` enabled.
|
|
env(regkey(alice, alice), ter(temBAD_REGKEY));
|
|
}
|
|
|
|
void
|
|
testPasswordSpent()
|
|
{
|
|
using namespace test::jtx;
|
|
|
|
testcase("Password spent");
|
|
Env env(*this);
|
|
Account const alice("alice");
|
|
Account const bob("bob");
|
|
env.fund(XRP(10000), alice, bob);
|
|
|
|
auto ar = env.le(alice);
|
|
BEAST_EXPECT(
|
|
ar->isFieldPresent(sfFlags) &&
|
|
((ar->getFieldU32(sfFlags) & lsfPasswordSpent) == 0));
|
|
|
|
env(regkey(alice, bob), sig(alice), fee(0));
|
|
|
|
ar = env.le(alice);
|
|
BEAST_EXPECT(
|
|
ar->isFieldPresent(sfFlags) &&
|
|
((ar->getFieldU32(sfFlags) & lsfPasswordSpent) ==
|
|
lsfPasswordSpent));
|
|
|
|
// The second SetRegularKey transaction with Fee=0 should fail.
|
|
env(regkey(alice, bob), sig(alice), fee(0), ter(telINSUF_FEE_P));
|
|
|
|
env.trust(bob["USD"](1), alice);
|
|
env(pay(bob, alice, bob["USD"](1)));
|
|
ar = env.le(alice);
|
|
BEAST_EXPECT(
|
|
ar->isFieldPresent(sfFlags) &&
|
|
((ar->getFieldU32(sfFlags) & lsfPasswordSpent) == 0));
|
|
}
|
|
|
|
void
|
|
testUniversalMask()
|
|
{
|
|
using namespace test::jtx;
|
|
|
|
testcase("Universal mask");
|
|
Env env(*this);
|
|
Account const alice("alice");
|
|
Account const bob("bob");
|
|
env.fund(XRP(10000), alice, bob);
|
|
|
|
auto jv = regkey(alice, bob);
|
|
jv[sfFlags.fieldName] = tfUniversalMask;
|
|
env(jv, ter(temINVALID_FLAG));
|
|
}
|
|
|
|
void
|
|
testTicketRegularKey()
|
|
{
|
|
using namespace test::jtx;
|
|
|
|
testcase("Ticket regular key");
|
|
Env env{*this};
|
|
Account const alice{"alice", KeyType::ed25519};
|
|
env.fund(XRP(1000), alice);
|
|
env.close();
|
|
|
|
// alice makes herself some tickets.
|
|
env(ticket::create(alice, 4));
|
|
env.close();
|
|
std::uint32_t ticketSeq{env.seq(alice)};
|
|
|
|
// Make sure we can give a regular key using a ticket.
|
|
Account const alie{"alie", KeyType::secp256k1};
|
|
env(regkey(alice, alie), ticket::use(--ticketSeq));
|
|
env.close();
|
|
|
|
// Disable alice's master key using a ticket.
|
|
env(fset(alice, asfDisableMaster),
|
|
sig(alice),
|
|
ticket::use(--ticketSeq));
|
|
env.close();
|
|
|
|
// alice should be able to sign using the regular key but not the
|
|
// master key.
|
|
std::uint32_t const aliceSeq{env.seq(alice)};
|
|
env(noop(alice), sig(alice), ter(tefMASTER_DISABLED));
|
|
env(noop(alice), sig(alie), ter(tesSUCCESS));
|
|
env.close();
|
|
BEAST_EXPECT(env.seq(alice) == aliceSeq + 1);
|
|
|
|
// Re-enable the master key using a ticket.
|
|
env(fclear(alice, asfDisableMaster),
|
|
sig(alie),
|
|
ticket::use(--ticketSeq));
|
|
env.close();
|
|
|
|
// Disable the regular key using a ticket.
|
|
env(regkey(alice, disabled), sig(alie), ticket::use(--ticketSeq));
|
|
env.close();
|
|
|
|
// alice should be able to sign using the master key but not the
|
|
// regular key.
|
|
env(noop(alice), sig(alice), ter(tesSUCCESS));
|
|
env(noop(alice), sig(alie), ter(tefBAD_AUTH));
|
|
env.close();
|
|
}
|
|
|
|
void
|
|
run() override
|
|
{
|
|
testDisableMasterKey();
|
|
testDisableMasterKeyAfterFix();
|
|
testDisabledRegularKey();
|
|
testDisableRegularKeyAfterFix();
|
|
testPasswordSpent();
|
|
testUniversalMask();
|
|
testTicketRegularKey();
|
|
}
|
|
};
|
|
|
|
BEAST_DEFINE_TESTSUITE(SetRegularKey, app, ripple);
|
|
|
|
} // namespace ripple
|