7c0c2419f7
Previously, the PeerFinder manager constructed with a Callback object provided by the owner which was used to perform operations like connecting, disconnecting, and sending messages. This made it difficult to change the overlay code because a single call into the PeerFinder could cause both OverlayImpl and PeerImp to be re-entered one or more times, sometimes while holding a recursive mutex. This change eliminates the callback by changing PeerFinder functions to return values indicating the action the caller should take. As a result of this change the PeerFinder no longer needs its own dedicated thread. OverlayImpl is changed to call into PeerFinder on a timer to perform periodic activities. Furthermore the Checker class used to perform connectivity checks has been refactored. It no longer uses an abstract base class, in order to not type-erase the handler passed to async_connect (ensuring compatibility with coroutines). To allow unit tests that don't need a network, the Logic class is now templated on the Checker type. Currently the Manager provides its own io_service. However, this can easily be changed so that the io_service is provided upon construction. Summary * Remove unused SiteFiles dependency injection * Remove Callback and update signatures for public APIs * Remove obsolete functions * Move timer to overlay * Steps toward a shared io_service * Templated, simplified Checker * Tidy up Checker declaration
src
Some of these directories come from entire outside repositories brought in using git-subtree. This means that the source files are inserted directly into the rippled repository. They can be edited and committed just as if they were normal files.
However, if you create a commit that contains files both from a subtree, and from the ripple source tree please use care when designing the commit message, since it will appear in the subtree's individual repository when the changes are pushed back to the upstream.
When submitting pull request, make sure that any commits which include files from subtrees are isolated - i.e. do not mix files from subtrees and ripple in the same commit. This way, the commit message will make sense. We don't want to see "Fix pathfinding bug with XRP" appearing in the LevelDB or Beast commit log, for example.
About git-subtree:
https://github.com/apenwarr/git-subtree
http://blogs.atlassian.com/2013/05/alternatives-to-git-submodule-git-subtree/
| dir | What |
|---|---|
| beast | Beast, the amazing cross-platform library. git@github.com:vinniefalco/Beast.git |
./beast
Beast, the amazing cross-platform library.
Repository
git@github.com:vinniefalco/Beast.git
Branch
master
HyperLevelDB
Ripple's fork of HyperLevelDB
Repository
git@github.com:ripple/HyperLevelDB.git
Branch
ripple-fork
LevelDB
Ripple's fork of LevelDB.
Repository
git@github.com:ripple/LevelDB.git
Branch
ripple-fork
LightningDB (a.k.a. MDB)
Ripple's fork of MDB, a fast memory-mapped key value database system.
Repository
git@github.com:ripple/LightningDB.git
Branch
ripple-fork
websocket
Ripple's fork of websocketpp has some incompatible changes and Ripple specific includes.
Repository
git@github.com:ripple/websocketpp.git
Branch
ripple-fork
protobuf
Ripple's fork of protobuf. We've changed some names in order to support the unity-style of build (a single .cpp added to the project, instead of linking to a separately built static library).
Repository
git@github.com:ripple/protobuf.git
Branch
master
NOTE Linux builds use the protobuf installed in /usr/lib. This will be fixed in a future revision.
SQLite
Not technically a subtree but included here because it is a direct copy of the official SQLite distributions available here: