Files
xahaud/src/test/rpc/TransactionHistory_test.cpp
Bronek Kozicki 53f8bf5b0b APIv2: remove tx_history and ledger_header (#4759)
Remove `tx_history` and `ledger_header` methods from API version 2.

Update `RPC::Handler` to allow for methods (or method implementations)
to be API version specific. This partially resolves #4727. We can now
store multiple handlers with the same name, as long as they belong to
different (non-overlapping) API versions. This necessarily impacts the
handler lookup algorithm and its complexity; however, there is no
performance loss on x86_64 architecture, and only minimal performance
loss on arm64 (around 10ns). This design change gives us extra
flexibility evolving the API in the future, including other parts of

In API version 2, `tx_history` and `ledger_header` are no longer
recognised; if they are called, `rippled` will return error
`unknownCmd`

Resolve #3638

Resolve #3539
2025-04-18 23:49:34 +09:00

173 lines
6.0 KiB
C++

//------------------------------------------------------------------------------
/*
This file is part of rippled: https://github.com/ripple/rippled
Copyright (c) 2012-2017 Ripple Labs Inc.
Permission to use, copy, modify, and/or distribute this software for any
purpose with or without fee is hereby granted, provided that the above
copyright notice and this permission notice appear in all copies.
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
ANY SPECIAL , DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
//==============================================================================
#include <ripple/protocol/jss.h>
#include <boost/container/static_vector.hpp>
#include <algorithm>
#include <test/jtx.h>
#include <test/jtx/Env.h>
#include <test/jtx/envconfig.h>
namespace ripple {
class TransactionHistory_test : public beast::unit_test::suite
{
void
testBadInput()
{
testcase("Invalid request params");
using namespace test::jtx;
Env env{*this, envconfig(no_admin)};
{
// no params
auto const result =
env.client().invoke("tx_history", {})[jss::result];
BEAST_EXPECT(result[jss::error] == "invalidParams");
BEAST_EXPECT(result[jss::status] == "error");
}
{
// test at 1 greater than the allowed non-admin limit
Json::Value params{Json::objectValue};
params[jss::start] = 10001; // limited to <= 10000 for non admin
auto const result =
env.client().invoke("tx_history", params)[jss::result];
BEAST_EXPECT(result[jss::error] == "noPermission");
BEAST_EXPECT(result[jss::status] == "error");
}
}
void
testCommandRetired()
{
testcase("Command retired from API v2");
using namespace test::jtx;
Env env{*this, envconfig(no_admin)};
Json::Value params{Json::objectValue};
params[jss::api_version] = 2;
auto const result =
env.client().invoke("tx_history", params)[jss::result];
BEAST_EXPECT(result[jss::error] == "unknownCmd");
BEAST_EXPECT(result[jss::status] == "error");
}
void
testRequest()
{
testcase("Basic request");
using namespace test::jtx;
Env env{*this};
// create enough transactions to provide some
// history...
size_t const numAccounts = 20;
boost::container::static_vector<Account, numAccounts> accounts;
for (size_t i = 0; i < numAccounts; ++i)
{
accounts.emplace_back("A" + std::to_string(i));
auto const& acct = accounts.back();
env.fund(XRP(10000), acct);
env.close();
if (i > 0)
{
auto const& prev = accounts[i - 1];
env.trust(acct["USD"](1000), prev);
env(pay(acct, prev, acct["USD"](5)));
}
env(offer(acct, XRP(100), acct["USD"](1)));
env.close();
// verify the latest transaction in env (offer)
// is available in tx_history.
Json::Value params{Json::objectValue};
params[jss::start] = 0;
auto result =
env.client().invoke("tx_history", params)[jss::result];
if (!BEAST_EXPECT(
result[jss::txs].isArray() && result[jss::txs].size() > 0))
return;
// search for a tx in history matching the last offer
bool const txFound = [&] {
auto const toFind = env.tx()->getJson(JsonOptions::none);
for (auto tx : result[jss::txs])
{
tx.removeMember(jss::inLedger);
tx.removeMember(jss::ledger_index);
if (toFind == tx)
return true;
}
return false;
}();
BEAST_EXPECT(txFound);
}
unsigned int start = 0;
unsigned int total = 0;
// also summarize the transaction types in this map
std::unordered_map<std::string, unsigned> typeCounts;
while (start < 120)
{
Json::Value params{Json::objectValue};
params[jss::start] = start;
auto result =
env.client().invoke("tx_history", params)[jss::result];
if (!BEAST_EXPECT(
result[jss::txs].isArray() && result[jss::txs].size() > 0))
break;
total += result[jss::txs].size();
start += 20;
for (auto const& t : result[jss::txs])
{
typeCounts[t[sfTransactionType.fieldName].asString()]++;
}
}
BEAST_EXPECT(total == 117);
BEAST_EXPECT(typeCounts[jss::AccountSet.c_str()] == 20);
BEAST_EXPECT(typeCounts[jss::TrustSet.c_str()] == 19);
BEAST_EXPECT(typeCounts[jss::Payment.c_str()] == 58);
BEAST_EXPECT(typeCounts[jss::OfferCreate.c_str()] == 20);
// also, try a request with max non-admin start value
{
Json::Value params{Json::objectValue};
params[jss::start] = 10000; // limited to <= 10000 for non admin
auto const result =
env.client().invoke("tx_history", params)[jss::result];
BEAST_EXPECT(result[jss::status] == "success");
BEAST_EXPECT(result[jss::index] == 10000);
}
}
public:
void
run() override
{
testBadInput();
testRequest();
testCommandRetired();
}
};
BEAST_DEFINE_TESTSUITE(TransactionHistory, rpc, ripple);
} // namespace ripple