Commit Graph

135 Commits

Author SHA1 Message Date
Richard Holland
88f844fd71 fix240918 2024-08-19 10:40:58 +10:00
Denis Angell
a3852763e7 Fix: Namespace Delete (OwnerCount) (#296)
* fix ns delete owner count
* add a new success code and refactor success checks, limit ns delete operations to 256 entries per txn
---------
Co-authored-by: Richard Holland <richard.holland@starstone.co.nz>
2024-03-25 08:37:08 +11:00
Denis Angell
858055c811 clang-format 2024-01-19 11:07:22 +01:00
Richard Holland
17ccec9ac5 Add additional checks for emitted txns 2024-01-17 15:39:02 +00:00
Denis Angell
475b6f7347 Amendment: Fix Xahau v1 (#231)
* FXV1: Meta Amount (#225)

* FXV1: Optional Offer Sequence (#224)

* FXV1: Patch Hooks OwnerDir (#236)

* FXV1:  Fix `Import` Quorum (#235)

* FXV1: Namespace Limit (#220)

* FXV1: allow duplicate entries in genesis mint transactor (#239)

* FXV1: Fix URIToken (#243)

* lite fixes for tsh issues (#244)

Co-authored-by: RichardAH <richard.holland@starstone.co.nz>
2023-12-21 16:21:17 +01:00
Denis Angell
ac694c7c90 Add HookParameters fee calc to all txs (#223) 2023-12-07 14:30:30 +01:00
RichardAH
c917977eb0 wildcard network (id=65535) ignores signature verification (#201)
* wildcard network (id=65535) ignores signature verification

* move isWildcardNetwork deeper to mimick normal signature checking in multisig

* again

* add wildcard test

* Update Transactor.cpp

* clang-format

* fix UNLReport

* move free pass

* update test for multisign

---------

Co-authored-by: Denis Angell <dangell@transia.co>
2023-11-21 18:47:08 +01:00
Denis Angell
70bd7c2ce7 Reintroduce Clang-Format & Levelization (#171)
* clang-format

* levelization

* clang-format

* update workflow (#172)

* update workflow

* Update build-in-docker.yml

* fix from `clang-format`

* Update Enum.h
2023-11-01 14:12:24 +01:00
Denis Angell
517c7a494b Fix warnings (#108)
* remove unused variable

* rewrite function for transparancy

* unnecessary move

* remove unused variable

* remove unused variables

* fix `nodiscard` warning and ogical-op-parentheses
2023-09-24 11:49:22 +02:00
Richard Holland
5e96402770 more governance debugging 2023-09-05 20:19:26 +00:00
Richard Holland
01a4df0584 fix uritoken buy bug, add dynamic memo fees 2023-08-17 10:36:55 +00:00
Richard Holland
152780b218 bug fixes 2023-07-12 08:02:04 +00:00
Richard Holland
234d811ce3 add issuer field to ttIMPORT, ensure that import pays a fee in every case except a first import against an account that doesn't exist and where the import doesn't specify an Issuer 2023-07-11 08:33:38 +00:00
RichardAH
98df71a919 Network ID logic should not be applied to pseudos 2023-05-30 14:39:22 +02:00
RichardAH
131bd9f4b3 ttImport (#65)
Add support for Burn2Mint and key import from original XRPL network in new txn type: ttIMPORT. Needs further testing.
2023-05-22 15:06:05 +02:00
Richard Holland
a56034b47c Fix FeeUint64->XRPAmount mismatch after merge 2023-04-06 12:43:12 +00:00
Richard Holland
a5ca117ff6 Merge remote-tracking branch 'ripple/develop' into dev 2023-04-06 09:36:24 +00:00
Richard Holland
4228946747 fix for fyeo-45 (#48) 2023-03-14 12:14:58 +00:00
Richard Holland
7c364377fe fix for fyeo-44 (#47) 2023-03-14 11:58:15 +00:00
Richard Holland
94d3d5a6bb fix for fyeo-43 (#46) 2023-03-14 11:04:52 +00:00
Richard Holland
8f02b24cc4 fix for fyeo-42 (#45) 2023-03-14 10:44:00 +00:00
Richard Holland
f732d724a2 fix for fyeo-41 (#44) 2023-03-14 10:30:27 +00:00
Richard Holland
5f5a947d6c additional fixes for #8 #10 and #14 2023-02-17 11:20:03 +00:00
Howard Hinnant
a82ad5ba76 Use Number for IOUAmount and STAmount arithmetic
* Guarded by amendment fixUniversalNumber
* Produces slightly better accuracy in some computations.
2023-02-07 15:43:28 -08:00
Ed Hennis
e4b17d1cf2 XRPFees: Fee setting and handling improvements (#4247)
* Introduces amendment `XRPFees`
* Convert fee voting and protocol messages to use XRPAmounts
* Includes Validations, Change transactions, the "Fees" ledger object,
  and subscription messages

* Improve handling of 0 drop reference fee with TxQ. For use with networks that do not want to require fees
* Note that fee escalation logic is still in place, which may cause the
  open ledger fee to rise if the network is busy. 0 drop transactions
  will still queue, and fee escalation can be effectively disabled by
  modifying the configuration on all nodes

* Change default network reserves to match Mainnet

* Name the new SFields *Drops (not *XRP)
* Reserve SField IDs for Hooks

* Clarify comments explaining the ttFEE transaction field validation
2023-02-02 16:20:35 -08:00
Richard Holland
45d4949b90 ensure emitted txns are preflighted correctly 2023-01-19 10:05:04 +00:00
Richard Holland
1d91f9c9e4 still better security against fake emitted txns being applied, preliminary preflight checking on emit 2023-01-18 09:58:10 +00:00
Richard Holland
1c3c9cd91f better protection against relaying or accepting emitted transactions 2023-01-17 11:29:27 +00:00
Richard Holland
e0533cae8d fix hook_pos bug 2023-01-13 10:04:51 +00:00
Richard Holland
7aa49cdf19 ensure that emitted txns don't need to specify network id 2022-12-21 22:29:18 +00:00
Richard Holland
0ef979a17b change HookOn to uint256 2022-12-20 10:55:28 +00:00
Richard Holland
39ecdb6795 Add NetworkID field to Transaction common fields, enforced when network id > 1024 2022-12-19 16:48:40 +00:00
Richard Holland
35bf8bef5a update featureBalanceRewards to operate on metdata (compiling not tested) 2022-12-17 09:33:14 +00:00
Richard Holland
44425f14f6 Balance Rewards amendment (compiling not tested) 2022-12-16 11:55:53 +00:00
Richard Holland
e4aa7db5cb increase size of hook state to 256 bytes, parameters too, change the reserve requirement to 1:1 for hook state, allow weak execution on rollback if hook_again was specified, add further state_set tests 2022-12-11 13:03:08 +00:00
Richard Holland
e99ffe29a3 https://github.com/XRPL-Labs/xrpld-hooks/issues/51 2022-09-19 12:48:09 +00:00
Richard Holland
27167bb866 [FOLD] First round of review changes 2022-08-29 10:25:22 +00:00
Richard Holland
8dd5490fb6 try to suppress emitted txns being sent over network 2022-06-21 09:42:30 +00:00
Richard Holland
4ea852b819 crash bug vector reserve 2022-05-26 10:58:23 +00:00
Richard Holland
4a8d904ed6 weak tsh bug fix 2022-05-26 09:48:02 +00:00
Richard Holland
4244a5a245 Merge remote-tracking branch 'ripple/develop' into develop 2022-05-20 08:05:08 +00:00
Richard Holland
5f4f2baa58 collect call logic bug 2022-05-17 12:35:23 +00:00
Richard Holland
f1a8b086b5 fix reference bug, add aaw test 2022-05-16 12:22:56 +00:00
Richard Holland
003bb9f63b fix txmeta issues 2022-05-16 11:42:25 +00:00
Richard Holland
b01bbcae5c mock txmeta and pass to weakly executed hooks, add meta_slot to access this data 2022-05-16 10:18:01 +00:00
Richard Holland
0bb38809be preliminary support for "second execution as weak" feature 2022-05-10 11:39:05 +00:00
Richard Holland
7dbfa071b1 split nonce into two apis, modify etxn_fee, add ledger_last_time, various other fee fixes 2022-05-09 13:01:54 +00:00
Richard Holland
636715fd20 refactor, guard_check, compiling but crash on validateGuards stream output (probably need a proxy class) 2022-05-05 18:38:47 +00:00
Richard Holland
90d14368e6 building 2022-04-21 12:17:01 +00:00
Richard Holland
8861467437 large refactor for weak/strong tsh, not compiling 2022-04-21 11:24:59 +00:00