13722 Commits

Author SHA1 Message Date
Scott Schurr
8266d9d598 Correct a technical flaw with NFT offers:
The existing code would, incorrectly, allow negative amounts in offers
for non-fungible tokens. Such offers would be handled very differently
depending on the context: a direct offer would fail with an error code
indicating an internal processing error, whereas brokered offers would
improperly succeed.

This commit introduces the `fixNFTokenNegOffer` amendment that detects
such offers during creation and returns an appropriate error code.

The commit also extends the existing code to allow for buy offers that
contain a `Destination` field, so that a specific broker can be set in
the offer.
2022-07-17 22:17:24 -07:00
Scott Schurr
0839a202c9 Reduce console noise coming from unit tests:
A few unit tests have historically generated a lot of noise
to the console from log writes.  This noise was not useful
and made it harder to locate actual test failures.

By changing the log level of these tests from
- severities::kError to
- severities::kDisabled
it was possible to remove that noise coming from the logs.
2022-07-17 22:17:24 -07:00
Ed Hennis
ee60b16b3a Lower log level of "addPathsForType" log message (fixes #4177) 2022-07-17 22:17:24 -07:00
Ed Hennis
18d437284e Lower the message level for missing optional doc components 2022-07-17 22:17:24 -07:00
Ed Hennis
1f75ba23ee Fix bitwise or on boolean operands warning / error 2022-07-17 22:17:24 -07:00
seelabs
723733a778 Catch missing node error when rotating database:
While there should never be a missing node when copying the SHAMap,
rippled should not terminate when there's an error rotating the
database. This patch aborts the database rotation rather than aborting rippled.
2022-07-17 22:17:24 -07:00
seelabs
8e6a0d418c Fix race conditions in shard:
ThreadSafetyAnalysis was used to identify race conditions in this file.
This analysis was modivated by a (rare) crash while running unit tests.

Add locks to Shard flagged by ThreadSafetyAnalysis
2022-07-17 22:17:24 -07:00
seelabs
f55913dcee Add support for clang's ThreadSafetyAnalysis 2022-07-17 22:17:24 -07:00
Chenna Keshava B S
e46d2bcf27 Correctly use the configured network_id parameter:
The existing code properly parses the network_id parameter from the
the configuration file, but it does not properly set up the code to
use the value correctly. As a result the configured `network_id` is
ignored.
2022-07-17 22:17:24 -07:00
Richard Holland
0ce86e2d4b fix debug builds of wasmedge 2022-07-12 12:01:14 +00:00
Richard Holland
ed70262aeb add hotpatch for wasmedge (for now) 2022-07-12 10:45:51 +00:00
Richard Holland
0692168f80 Update build engine for static wasmedge builds 2022-07-12 10:00:35 +00:00
Chenna Keshava B S
d632f9f6c8 Properly handle incorrect port numbers in parseURL (fixes #4200) 2022-07-11 09:56:39 -07:00
Chenna Keshava B S
3172a816fa Describe resolution for common SOCI-related build errors 2022-07-11 09:56:39 -07:00
Richard Holland
99eaa9201a static builds / change overflow to overflow_float for some compilers 2022-07-11 15:55:14 +00:00
Ikko Ashimine
4e724794c5 Fix typo in Consensus.h (#4179)
whenver -> whenever
2022-07-11 14:03:26 +02:00
Richard Holland
ce6569f58c - 2022-07-11 11:39:54 +00:00
Richard Holland
2e28ff3b6d enable static wasmedge 2022-07-11 09:31:24 +00:00
RichardAH
610436d737 Add book_changes rpc (#4212) 2022-07-11 09:29:31 +02:00
RichardAH
0ee6f15b35 Create CONTRIBUTING.md, list maintainers and outline repo policies (#4214) 2022-07-09 20:37:13 +03:00
Richard Holland
006524a10a account for new state objects and owner reserves better 2022-06-23 12:55:03 +00:00
Richard Holland
043bdaf379 Merge remote-tracking branch 'richardah/BookChanges191' into develop 2022-06-21 10:31:13 +00:00
Richard Holland
8dd5490fb6 try to suppress emitted txns being sent over network 2022-06-21 09:42:30 +00:00
Richard Holland
27846df19c Add book_changes rpc 2022-06-16 14:33:06 +00:00
Richard Holland
9ff1290093 Fix escrowid and offerid 2022-06-16 09:22:23 +00:00
Richard Holland
602c280dd4 use txnid instead of emitnonce where seq is not available in applicable transactors 2022-06-16 09:14:36 +00:00
Richard Holland
691f674743 bug fixes 2022-06-16 08:38:32 +00:00
Richard Holland
d3f6c4ef2d fix bug in iouescrow, hook macro 2022-06-14 12:52:55 +00:00
Richard Holland
2793f25acc merged IOUEscrow amendment 2022-06-14 09:04:43 +00:00
Richard Holland
d53c6d905a preliminary work on hook_namespace api 2022-06-14 08:48:08 +00:00
Richard Holland
3fcc79d600 test case for multi-escrow emitted 2022-06-14 08:40:13 +00:00
Richard Holland
1fa87c21be add emitnonce support to various transactors, object ids to various tx formats 2022-06-13 16:17:22 +00:00
Richard Holland
e89475e76c https://github.com/XRPL-Labs/xrpld-hooks/issues/42 2022-06-09 11:35:34 +00:00
Richard Holland
12f1609796 add noduplicate to _g 2022-06-07 15:32:31 +00:00
Richard Holland
82e908e853 update peggy for v2 2022-06-07 12:07:56 +00:00
Richard Holland
cb3edacd63 fix variable emit details size in example hooks 2022-06-07 11:23:58 +00:00
Richard Holland
d31ff6eb6e notary example updated and working on v2 2022-06-07 09:44:33 +00:00
Richard Holland
d6011350ee misc example changes to support v2 2022-06-07 09:43:19 +00:00
Richard Holland
e3c792e68b emitdetails bug 2022-06-07 09:42:27 +00:00
Richard Holland
d26f6ff995 remove old example and test dirs 2022-06-06 14:07:33 +00:00
Richard Holland
5f74392bcb begin rework for js tests and hook examples 2022-06-06 14:05:17 +00:00
Richard Holland
d452f9ca5a missing whitelist function 2022-06-06 12:55:24 +00:00
Richard Holland
3f7eaa5f7c fix multiplier bug, multipliers lower than 1 are necessary 2022-06-03 09:18:10 +00:00
Richard Holland
df111bc279 wce calc error 2022-06-02 19:53:57 +00:00
Richard Holland
0fe9fd2f81 division safety, seperate leb functions to signed and unsigned 2022-06-02 15:09:33 +00:00
Richard Holland
6571af7490 reprogram the guard_check function to fix several issues including worst case execution computation 2022-06-02 12:48:01 +00:00
Richard Holland
c87fa5210b add ledger_keylet hookapi 2022-06-02 08:35:16 +00:00
Richard Holland
848097ffac update hook api 2022-05-30 10:49:22 +00:00
Richard Holland
f225003091 testcases for xfl log and root 2022-05-30 10:29:37 +00:00
Richard Holland
869b66f06f impl missing float funcs that were documented but not implemented 2022-05-30 10:17:19 +00:00