From fd1908f5b6f1e9b8f061510056090a7b4965eee8 Mon Sep 17 00:00:00 2001
From: Bronek Kozicki <brok@incorrekt.com>
Date: Mon, 5 Aug 2024 17:05:12 +0100
Subject: [PATCH] Factor out Transactor::trapTransaction (#5087)

---
 src/xrpld/app/tx/detail/Transactor.cpp | 10 +++++++++-
 src/xrpld/app/tx/detail/Transactor.h   |  2 ++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/xrpld/app/tx/detail/Transactor.cpp b/src/xrpld/app/tx/detail/Transactor.cpp
index 323233f65..46c9cd064 100644
--- a/src/xrpld/app/tx/detail/Transactor.cpp
+++ b/src/xrpld/app/tx/detail/Transactor.cpp
@@ -1753,6 +1753,14 @@ Transactor::doAgainAsWeak(
     }
 }
 
+// The sole purpose of this function is to provide a convenient, named
+// location to set a breakpoint, to be used when replaying transactions.
+void
+Transactor::trapTransaction(uint256 txHash) const
+{
+    JLOG(j_.debug()) << "Transaction trapped: " << txHash;
+}
+
 //------------------------------------------------------------------------------
 std::pair<TER, bool>
 Transactor::operator()()
@@ -1795,7 +1803,7 @@ Transactor::operator()()
     if (auto const& trap = ctx_.app.trapTxID();
         trap && *trap == ctx_.tx.getTransactionID())
     {
-        JLOG(j_.debug()) << "Transaction trapped: " << *trap;
+        trapTransaction(*trap);
     }
 
     auto result = ctx_.preclaimResult;
diff --git a/src/xrpld/app/tx/detail/Transactor.h b/src/xrpld/app/tx/detail/Transactor.h
index aec16f3e4..2c8e102a5 100644
--- a/src/xrpld/app/tx/detail/Transactor.h
+++ b/src/xrpld/app/tx/detail/Transactor.h
@@ -266,6 +266,8 @@ private:
     checkSingleSign(PreclaimContext const& ctx);
     static NotTEC
     checkMultiSign(PreclaimContext const& ctx);
+
+    void trapTransaction(uint256) const;
 };
 
 /** Performs early sanity checks on the txid */