From fcdc64fa4099764ec5e0734d9ad48facf6928615 Mon Sep 17 00:00:00 2001 From: Scott Determan Date: Fri, 15 Sep 2023 00:02:31 -0400 Subject: [PATCH] Fix Windows build by removing two unused declarations (#4708) Remove the `verify` and `message` function declarations. The explicit instantiation requests could not be completed because there were no implementations for those two member functions. It is helpful that the Microsoft (MSVC) compiler on Windows appears to be strict when it comes to template instantiation. This resolves the warning: XChainAttestations.h(450): warning C4661: 'bool ripple::XChainAttestationsBase::verify(void) const': no suitable definition provided for explicit template instantiation request --- src/ripple/protocol/XChainAttestations.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/ripple/protocol/XChainAttestations.h b/src/ripple/protocol/XChainAttestations.h index 8fa1a0311..b99a0b59a 100644 --- a/src/ripple/protocol/XChainAttestations.h +++ b/src/ripple/protocol/XChainAttestations.h @@ -437,16 +437,6 @@ public: template void emplace_back(T&& att); - - // verify that all the signatures attest to transaction data. - [[nodiscard]] bool - verify() const; - -protected: - // Return the message that was expected to be signed by the attesters given - // the data to be proved. - [[nodiscard]] std::vector - message() const; }; template