Improve reporting for bad validators.txt.

src/Config.h

@@ -4,7 +4,9 @@
 #include <string>
 
 #define SYSTEM_NAME		"newcoin"
+#define VALIDATORS_SITE		"redstem.com"
 
+#define VALIDATORS_FILE_NAME	"validators.txt"
 const int SYSTEM_PEER_PORT=6561;
 
 // Allow anonymous DH.

src/RPCServer.cpp

@@ -22,10 +22,8 @@
 #include "AccountState.h"
 
 #define VALIDATORS_FETCH_SECONDS	30
-#define VALIDATORS_FILE_NAME		"validators.txt"
 #define VALIDATORS_FILE_PATH		"/" VALIDATORS_FILE_NAME
 #define VALIDATORS_FILE_BYTES_MAX	(50 << 10)
-#define VALIDATORS_SITE				"redstem.com"
 
 /*
 Just read from wire until the entire request is in.

src/UniqueNodeList.cpp

@@ -1020,9 +1020,14 @@ int UniqueNodeList::iSourceScore(validatorSource vsWhy)
 // Queue a domain for a single attempt fetch a newcoin.txt.
 // --> strComment: only used on vsManual
 // YYY As a lot of these may happen at once, would be nice to wrap multiple calls in a transaction.
-void UniqueNodeList::nodeAddDomain(std::string strDomain, validatorSource vsWhy, std::string strComment)
+void UniqueNodeList::nodeAddDomain(const std::string& strDomain, validatorSource vsWhy, std::string strComment)
 {
 	// YYY Would be best to verify strDomain is a valid domain.
+	// std::cerr << str(boost::format("nodeAddDomain: '%s' %c '%s'")
+	//	% strDomain
+	//	% vsWhy
+	//	% strComment) << std::endl;
+
 	seedDomain	sdCurrent;
 
 	bool		bFound		= getSeedDomains(strDomain, sdCurrent);
@@ -1211,6 +1216,10 @@ void UniqueNodeList::nodeDefault(std::string strValidators) {
 			nodeAddDomain(strValidator, vsValidator);
 		}
 	}
+	else
+	{
+		std::cerr << "WARNING: '" VALIDATORS_FILE_NAME "' missing [" SECTION_VALIDATORS "]." << std::endl;
+	}
 }
 
 // vim:ts=4

src/UniqueNodeList.h

@@ -116,7 +116,7 @@ public:
 	void start();
 
 	void nodeAddPublic(NewcoinAddress naNodePublic, std::string strComment);
-	void nodeAddDomain(std::string strDomain, validatorSource vsWhy, std::string strComment="");
+	void nodeAddDomain(const std::string& strDomain, validatorSource vsWhy, std::string strComment="");
 	void nodeRemove(NewcoinAddress naNodePublic);
 	void nodeDefault(std::string strValidators);
 	void nodeReset();