ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-12-06 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove STAmountSO::soTime and soTime2:

Browse Source 
STAmount::soTime and soTime2 were time based "amendment like"
switches to control small changes in behavior for STAmount.
soTime2, which was the most recent, was dated Feb 27, 2016.
That's over 3 years ago.

The main reason to retain these soTimes would be to replay
old transactions.  The likelihood of needing to replay a
transaction from over three years ago is pretty low.  So it
makes sense to remove these soTime values.

In Flow_test the testZeroOutputStep() test is removed.  That
test started to fail when the STAmount::soTimes were removed.
I checked with the original author of the test.  He said
that the code being tested by that unit test has been removed,
so it makes sense to remove the test.  That test is removed.
This commit is contained in:
Scott Schurr
2019-12-09 12:33:54 -08:00
committed by Manoj doshi
parent f7fffee28d
commit fc0a082700
7 changed files with 40 additions and 197 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/test/app/Flow_test.cpp
View File

@@ -492,11 +492,6 @@ struct Flow_test : public beast::unit_test::suite
// pass. This test checks that the payment produces 1 EUR, as expected.
Env env (*this, features);
auto const closeTime = STAmountSO::soTime2 +
100 * env.closed ()->info ().closeTimeResolution;
env.close (closeTime);
env.fund (XRP (10000), alice, bob, carol, gw);
env.trust (USD (1000), alice, bob, carol);
env.trust (EUR (1000), alice, bob, carol);
@@ -1249,40 +1244,6 @@ struct Flow_test : public beast::unit_test::suite
ter(temBAD_PATH));
}
void
testZeroOutputStep()
{
testcase("Zero Output Step");
using namespace jtx;
auto const alice = Account("alice");
auto const bob = Account("bob");
auto const carol = Account("carol");
auto const gw = Account("gw");
auto const USD = gw["USD"];
auto const EUR = gw["EUR"];
auto const features = supported_amendments();
Env env(*this, features);
env.fund(XRP(10000), alice, bob, carol, gw);
env.trust(USD(1000), alice, bob, carol);
env.trust(EUR(1000), alice, bob, carol);
env(pay(gw, alice, USD(100)));
env(pay(gw, bob, USD(100)));
env(pay(gw, bob, EUR(100)));
env.close();
env(offer(bob, USD(100), EUR(100)));
env(offer(bob, EUR(100), XRP(0.000001)));
env.close();
env(pay(alice, carol, XRP(1)),
path(~EUR, ~XRP),
sendmax(USD(1)),
txflags(tfPartialPayment),
ter(tecPATH_DRY));
}
void testWithFeats(FeatureBitset features)
{
using namespace jtx;
@@ -1311,7 +1272,6 @@ struct Flow_test : public beast::unit_test::suite
void run() override
{
testLimitQuality();
testZeroOutputStep();
testRIPD1443(true);
testRIPD1443(false);
testRIPD1449(true);