From fc03403004467f7fa73c3c27d3a0af43df4da822 Mon Sep 17 00:00:00 2001
From: Arthur Britto <ahbritto@gmail.com>
Date: Wed, 2 Jan 2013 23:57:11 -0800
Subject: [PATCH] Clean up errors messages.

---
 src/cpp/ripple/TransactionErr.cpp | 23 +++++++++++------------
 src/cpp/ripple/TransactionErr.h   |  1 -
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/src/cpp/ripple/TransactionErr.cpp b/src/cpp/ripple/TransactionErr.cpp
index a6c444679..df2d62cef 100644
--- a/src/cpp/ripple/TransactionErr.cpp
+++ b/src/cpp/ripple/TransactionErr.cpp
@@ -8,8 +8,8 @@ bool transResultInfo(TER terCode, std::string& strToken, std::string& strHuman)
 		const char*		cpToken;
 		const char*		cpHuman;
 	} transResultInfoA[] = {
-		{	tecCLAIM,				"tecCLAIM",					"Fee claim. Sequence used. No action."					},
-		{	tecDIR_FULL,			"tecDIR_FULL",				"Can not add entry to full dir."						},
+		{	tecCLAIM,				"tecCLAIM",					"Fee claimed. Sequence used. No action."				},
+		{	tecDIR_FULL,			"tecDIR_FULL",				"Can not add entry to full directory."					},
 		{	tecINSUF_RESERVE_LINE,	"tecINSUF_RESERVE_LINE",	"Insufficent reserve to add trust line."				},
 		{	tecINSUF_RESERVE_OFFER,	"tecINSUF_RESERVE_OFFER",	"Insufficent reserve to create offer."					},
 		{	tecNO_DST,				"tecNO_DST",				"Destination does not exist. Send XRP to create it."	},
@@ -23,33 +23,32 @@ bool transResultInfo(TER terCode, std::string& strToken, std::string& strHuman)
 		{	tefALREADY,				"tefALREADY",				"The exact transaction was already in this ledger."		},
 		{	tefBAD_ADD_AUTH,		"tefBAD_ADD_AUTH",			"Not authorized to add account."						},
 		{	tefBAD_AUTH,			"tefBAD_AUTH",				"Transaction's public key is not authorized."			},
-		{	tefBAD_CLAIM_ID,		"tefBAD_CLAIM_ID",			"Malformed."											},
+		{	tefBAD_CLAIM_ID,		"tefBAD_CLAIM_ID",			"Malformed: Bad claim id."								},
 		{	tefBAD_GEN_AUTH,		"tefBAD_GEN_AUTH",			"Not authorized to claim generator."					},
 		{	tefBAD_LEDGER,			"tefBAD_LEDGER",			"Ledger in unexpected state."							},
 		{	tefCLAIMED,				"tefCLAIMED",				"Can not claim a previously claimed account."			},
 		{	tefEXCEPTION,			"tefEXCEPTION",				"Unexpected program state."								},
 		{	tefCREATED,				"tefCREATED",				"Can't add an already created account."					},
 		{	tefGEN_IN_USE,			"tefGEN_IN_USE",			"Generator already in use."								},
-		{	tefPAST_SEQ,			"tefPAST_SEQ",				"This sequence number has already past"					},
+		{	tefPAST_SEQ,			"tefPAST_SEQ",				"This sequence number has already past."				},
 
 		{	telLOCAL_ERROR,			"telLOCAL_ERROR",			"Local failure."										},
-		{	telBAD_PATH_COUNT,		"telBAD_PATH_COUNT",		"Malformed: too many paths."							},
+		{	telBAD_PATH_COUNT,		"telBAD_PATH_COUNT",		"Malformed: Too many paths."							},
 		{	telINSUF_FEE_P,			"telINSUF_FEE_P",			"Fee insufficient."										},
 
 		{	temMALFORMED,			"temMALFORMED",				"Malformed transaction."								},
 		{	temBAD_AMOUNT,			"temBAD_AMOUNT",			"Can only send positive amounts."						},
 		{	temBAD_AUTH_MASTER,		"temBAD_AUTH_MASTER",		"Auth for unclaimed account needs correct master key."	},
 		{	temBAD_FEE,				"temBAD_FEE",				"Invalid fee, negative or not XRP."						},
-		{	temBAD_EXPIRATION,		"temBAD_EXPIRATION",		"Malformed."											},
-		{	temBAD_ISSUER,			"temBAD_ISSUER",			"Malformed."											},
+		{	temBAD_EXPIRATION,		"temBAD_EXPIRATION",		"Malformed: Bad expiration."							},
+		{	temBAD_ISSUER,			"temBAD_ISSUER",			"Malformed: Bad issuer."								},
 		{	temBAD_LIMIT,			"temBAD_LIMIT",				"Limits must be non-negative."							},
-		{	temBAD_OFFER,			"temBAD_OFFER",				"Malformed."											},
-		{	temBAD_PATH,			"temBAD_PATH",				"Malformed."											},
-		{	temBAD_PATH_LOOP,		"temBAD_PATH_LOOP",			"Malformed."											},
+		{	temBAD_OFFER,			"temBAD_OFFER",				"Malformed: Bad offer."									},
+		{	temBAD_PATH,			"temBAD_PATH",				"Malformed: Bad path."									},
+		{	temBAD_PATH_LOOP,		"temBAD_PATH_LOOP",			"Malformed: Loop in path."								},
 		{	temBAD_PUBLISH,			"temBAD_PUBLISH",			"Malformed: Bad publish."								},
 		{	temBAD_TRANSFER_RATE,	"temBAD_TRANSFER_RATE",		"Malformed: Transfer rate must be >= 1.0"				},
-		{	temBAD_SET_ID,			"temBAD_SET_ID",			"Malformed."											},
-		{	temBAD_SEQUENCE,		"temBAD_SEQUENCE",			"Malformed: Sequence in not in the past."				},
+		{	temBAD_SEQUENCE,		"temBAD_SEQUENCE",			"Malformed: Sequence is not in the past."				},
 		{	temDST_IS_SRC,			"temDST_IS_SRC",			"Destination may not be source."						},
 		{	temDST_NEEDED,			"temDST_NEEDED",			"Destination not specified."							},
 		{	temINVALID,				"temINVALID",				"The transaction is ill-formed."						},
diff --git a/src/cpp/ripple/TransactionErr.h b/src/cpp/ripple/TransactionErr.h
index 1a497598f..238ef7ddf 100644
--- a/src/cpp/ripple/TransactionErr.h
+++ b/src/cpp/ripple/TransactionErr.h
@@ -37,7 +37,6 @@ enum TER	// aka TransactionEngineResult
 	temBAD_PUBLISH,
 	temBAD_TRANSFER_RATE,
 	temBAD_SEQUENCE,
-	temBAD_SET_ID,
 	temDST_IS_SRC,
 	temDST_NEEDED,
 	temINVALID,