ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-11-04 18:55:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #102 from Xahau/invoke-tests

Browse Source 
add invoke tests
This commit is contained in:
RichardAH
2023-09-19 11:23:16 +02:00
committed by GitHub
parent 9b089bee94 fb44359988
commit e7cd845d93
3 changed files with 263 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Builds/CMake/RippledCore.cmake
View File

@@ -714,6 +714,7 @@ if (tests)
src/test/app/Freeze_test.cpp
src/test/app/HashRouter_test.cpp
src/test/app/Import_test.cpp
src/test/app/Invoke_test.cpp
src/test/app/LedgerHistory_test.cpp
src/test/app/LedgerLoad_test.cpp
src/test/app/LedgerMaster_test.cpp

7
src/ripple/app/tx/impl/Invoke.cpp
View File

@@ -39,8 +39,13 @@ Invoke::preflight(PreflightContext const& ctx)
auto& tx = ctx.tx;
if (tx.getFieldVL(sfBlob).size() > (128*1024))
if (tx.getFieldVL(sfBlob).size() > (128 * 1024))
{
JLOG(ctx.j.warn())
<< "Invoke: blob was more than 128kib "
<< tx.getTransactionID();
return temMALFORMED;
}
return preflight2(ctx);
}

256
src/test/app/Invoke_test.cpp Normal file
View File

@@ -0,0 +1,256 @@
//------------------------------------------------------------------------------
/*
This file is part of rippled: https://github.com/ripple/rippled
Copyright (c) 2023 XRPLF
Permission to use, copy, modify, and/or distribute this software for any
purpose with or without fee is hereby granted, provided that the above
copyright notice and this permission notice appear in all copies.
THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
ANY SPECIAL , DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
//==============================================================================
#include <test/jtx.h>
namespace ripple {
namespace test {
class Invoke_test : public beast::unit_test::suite
{
std::unique_ptr<Config>
makeNetworkConfig(uint32_t networkID)
{
using namespace jtx;
return envconfig([&](std::unique_ptr<Config> cfg) {
cfg->NETWORK_ID = networkID;
Section config;
config.append(
{"reference_fee = 10",
"account_reserve = 1000000",
"owner_reserve = 200000"});
auto setup = setup_FeeVote(config);
cfg->FEES = setup;
return cfg;
});
}
static Json::Value
invoke(jtx::Account const& account)
{
using namespace jtx;
Json::Value jv;
jv[jss::TransactionType] = jss::Invoke;
jv[jss::Account] = account.human();
return jv;
}
XRPAmount
calcParamFee(Json::Value jv)
{
uint64_t paramBytes = 0;
auto const& params = jv["HookParameters"];
for (auto const& param : params)
{
auto const& hparam = param["HookParameter"];
paramBytes +=
(hparam.isMember("HookParameterName") ?
hparam["HookParameterName"].asString().size() / 2 : 0) +
(hparam.isMember("HookParameterValue") ?
hparam["HookParameterValue"].asString().size() / 2 : 0);
}
return XRPAmount { static_cast<XRPAmount>(paramBytes) };
}
void
testInvalidPreflight1(FeatureBitset features)
{
testcase("invoke invalid preflight");
using namespace test::jtx;
using namespace std::literals;
test::jtx::Env env{*this, makeNetworkConfig(21337)};
auto const alice = Account("alice");
auto const bob = Account("bob");
env.fund(XRP(1000), alice, bob);
env.close();
std::string jsonBlob = R"json({
"mykey": "DEADBEEF",
})json";
//----------------------------------------------------------------------
// preflight
// temDISABLED
}
void
testInvalidPreflight(FeatureBitset features)
{
testcase("invoke invalid preflight");
using namespace test::jtx;
using namespace std::literals;
test::jtx::Env env{*this, makeNetworkConfig(21337)};
auto const alice = Account("alice");
env.fund(XRP(1000), alice);
env.close();
//----------------------------------------------------------------------
// preflight
// temMALFORMED - Invoke: blob was more than 128kib
{
ripple::Blob blob;
blob.resize(129 * 1024);
auto jv = invoke(alice);
jv[sfBlob.jsonName] = strHex(blob);
XRPAmount const extraFee = XRPAmount{ static_cast<XRPAmount>(blob.size()) };
env(jv, fee(10 + extraFee), ter(temMALFORMED));
}
}
void
testInvalidPreclaim(FeatureBitset features)
{
testcase("invoke invalid preclaim");
using namespace test::jtx;
using namespace std::literals;
//----------------------------------------------------------------------
// preclaim
// temDISABLED
{
test::jtx::Env env{*this, makeNetworkConfig(21337), features - featureHooks};
auto const alice = Account("alice");
env.fund(XRP(1000), alice);
env.close();
env(invoke(alice), ter(temDISABLED));
}
// terNO_ACCOUNT
{
test::jtx::Env env{*this, makeNetworkConfig(21337)};
auto const feeDrops = env.current()->fees().base;
auto const alice = Account("alice");
env.memoize(alice);
Json::Value tx = invoke(alice);
tx[jss::Sequence] = 0;
env(tx, fee(feeDrops), ter(terNO_ACCOUNT));
}
// tecNO_TARGET
{
test::jtx::Env env{*this, makeNetworkConfig(21337)};
auto const feeDrops = env.current()->fees().base;
auto const alice = Account("alice");
auto const bob = Account("bob");
env.memoize(bob);
env.fund(XRP(1000), alice);
env.close();
Json::Value tx = invoke(alice);
tx[jss::Destination] = bob.human();
env(tx, fee(feeDrops), ter(tecNO_TARGET));
}
}
void
testInvoke(FeatureBitset features)
{
testcase("invoke");
using namespace test::jtx;
using namespace std::literals;
test::jtx::Env env{*this, makeNetworkConfig(21337), features};
auto const feeDrops = env.current()->fees().base;
auto const alice = Account("alice");
auto const bob = Account("bob");
env.fund(XRP(1000), alice, bob);
env.close();
// W/ Blob
{
ripple::Blob blob;
blob.resize(128 * 1024);
auto jv = invoke(alice);
jv[sfBlob.jsonName] = strHex(blob);
XRPAmount const extraFee = XRPAmount{ static_cast<XRPAmount>(blob.size()) };
env(jv, fee(feeDrops + extraFee), ter(tesSUCCESS));
}
// No Destination
{
env(invoke(alice), ter(tesSUCCESS));
}
// W/ Destination
{
Json::Value tx = invoke(alice);
tx[jss::Destination] = bob.human();
env(tx, ter(tesSUCCESS));
}
// W/ Params
{
auto jv = invoke(alice);
jv[jss::HookParameters] = Json::Value{Json::arrayValue};
jv[jss::HookParameters][0U] = Json::Value{};
jv[jss::HookParameters][0U][jss::HookParameter] = Json::Value{};
jv[jss::HookParameters][0U][jss::HookParameter]
[jss::HookParameterName] = "CAFE";
jv[jss::HookParameters][0U][jss::HookParameter]
[jss::HookParameterValue] = "";
XRPAmount extraFee = calcParamFee(jv);
env(jv, fee(feeDrops + extraFee), ter(tesSUCCESS));
}
}
public:
void
run() override
{
using namespace test::jtx;
FeatureBitset const all{supported_amendments()};
testWithFeats(all);
}
void
testWithFeats(FeatureBitset features)
{
testInvalidPreflight(features);
testInvalidPreclaim(features);
testInvoke(features);
}
};
BEAST_DEFINE_TESTSUITE(Invoke, app, ripple);
} // namespace test
} // namespace ripple