diff --git a/src/ripple/net/impl/RPCCall.cpp b/src/ripple/net/impl/RPCCall.cpp index f11f831e0..597e2134c 100644 --- a/src/ripple/net/impl/RPCCall.cpp +++ b/src/ripple/net/impl/RPCCall.cpp @@ -1894,7 +1894,8 @@ fromNetwork( constexpr auto RPC_REPLY_MAX_BYTES = megabytes(256); using namespace std::chrono_literals; - auto constexpr RPC_NOTIFY = 10min; + // auto constexpr RPC_NOTIFY = 10min; // Wietse: lolwut 10 minutes for one HTTP call? + auto constexpr RPC_NOTIFY = 30s; HTTPClient::request( bSSL, diff --git a/src/ripple/net/impl/RPCSub.cpp b/src/ripple/net/impl/RPCSub.cpp index 8b052e817..8294f871a 100644 --- a/src/ripple/net/impl/RPCSub.cpp +++ b/src/ripple/net/impl/RPCSub.cpp @@ -78,12 +78,14 @@ public: { std::lock_guard sl(mLock); - if (mDeque.size() >= eventQueueMax) - { - // Drop the previous event. - JLOG(j_.warn()) << "RPCCall::fromNetwork drop"; - mDeque.pop_back(); - } + // Wietse: we're not going to limit this, this is admin-port only, scale accordingly + // Dropping events just like this results in inconsistent data on the receiving end + // if (mDeque.size() >= eventQueueMax) + // { + // // Drop the previous event. + // JLOG(j_.warn()) << "RPCCall::fromNetwork drop"; + // mDeque.pop_back(); + // } auto jm = broadcast ? j_.debug() : j_.info(); JLOG(jm) << "RPCCall::fromNetwork push: " << jvObj; @@ -182,7 +184,8 @@ private: } private: - enum { eventQueueMax = 32 }; + // Wietse: we're not going to limit this, this is admin-port only, scale accordingly + // enum { eventQueueMax = 32 }; boost::asio::io_service& m_io_service; JobQueue& m_jobQueue;