From dcba79be48bb3b8d331b943e8089000ba29f92e4 Mon Sep 17 00:00:00 2001 From: Scott Schurr Date: Mon, 19 Apr 2021 14:45:44 -0700 Subject: [PATCH] Only warn on non-pseudo transactions without accounts: Closes #3153 --- src/ripple/app/rdb/impl/RelationalDBInterface_nodes.cpp | 8 +++++--- src/ripple/app/rdb/impl/RelationalDBInterface_shards.cpp | 4 +++- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/ripple/app/rdb/impl/RelationalDBInterface_nodes.cpp b/src/ripple/app/rdb/impl/RelationalDBInterface_nodes.cpp index 394770f79..49d2a2f2c 100644 --- a/src/ripple/app/rdb/impl/RelationalDBInterface_nodes.cpp +++ b/src/ripple/app/rdb/impl/RelationalDBInterface_nodes.cpp @@ -317,12 +317,14 @@ saveValidatedLedger( JLOG(j.trace()) << "ActTx: " << sql; *db << sql; } - else + else if (auto const sleTxn = acceptedLedgerTx->getTxn(); + !isPseudoTx(*sleTxn)) { + // It's okay for pseudo transactions to not affect any + // accounts. But otherwise... JLOG(j.warn()) << "Transaction in ledger " << seq << " affects no accounts"; - JLOG(j.warn()) << acceptedLedgerTx->getTxn()->getJson( - JsonOptions::none); + JLOG(j.warn()) << sleTxn->getJson(JsonOptions::none); } *db diff --git a/src/ripple/app/rdb/impl/RelationalDBInterface_shards.cpp b/src/ripple/app/rdb/impl/RelationalDBInterface_shards.cpp index c433b7025..acda4ea1d 100644 --- a/src/ripple/app/rdb/impl/RelationalDBInterface_shards.cpp +++ b/src/ripple/app/rdb/impl/RelationalDBInterface_shards.cpp @@ -274,8 +274,10 @@ updateLedgerDBs( JLOG(j.trace()) << "shard " << index << " account transaction: " << sql; } - else + else if (!isPseudoTx(*item.first)) { + // It's okay for pseudo transactions to not affect any + // accounts. But otherwise... JLOG(j.warn()) << "shard " << index << " transaction in ledger " << sSeq << " affects no accounts";