Some code cleanups tagged by static analysis

This commit is contained in:
seelabs
2021-06-07 11:26:27 -04:00
committed by manojsdoshi
parent 78bc2727f7
commit cd27b5f2bd
28 changed files with 60 additions and 57 deletions

View File

@@ -52,7 +52,7 @@ class PerfLog_test : public beast::unit_test::suite
beast::Journal j_;
bool stopSignaled{false};
Fixture(beast::Journal const& j) : j_(j)
explicit Fixture(beast::Journal j) : j_(j)
{
}

View File

@@ -1193,7 +1193,7 @@ class DatabaseShard_test : public TestBase
for (std::uint32_t i = 1; i <= 2; ++i)
waitShard(*db, i);
auto const finalShards{std::move(db->getShardInfo()->finalized())};
auto const finalShards{db->getShardInfo()->finalized()};
for (std::uint32_t shardIndex : {1, 2})
BEAST_EXPECT(boost::icl::contains(finalShards, shardIndex));
}
@@ -1209,7 +1209,7 @@ class DatabaseShard_test : public TestBase
for (std::uint32_t i = 1; i <= 2; ++i)
waitShard(*db, i);
auto const finalShards{std::move(db->getShardInfo()->finalized())};
auto const finalShards{db->getShardInfo()->finalized()};
for (std::uint32_t shardIndex : {1, 2})
BEAST_EXPECT(boost::icl::contains(finalShards, shardIndex));
@@ -1358,7 +1358,7 @@ class DatabaseShard_test : public TestBase
for (std::uint32_t i = 1; i <= shardCount; ++i)
waitShard(*db, i);
auto const final{std::move(db->getShardInfo()->finalized())};
auto const final{db->getShardInfo()->finalized()};
for (std::uint32_t shardIndex : {1, 2, 3, 4})
BEAST_EXPECT(boost::icl::contains(final, shardIndex));
@@ -1417,7 +1417,7 @@ class DatabaseShard_test : public TestBase
for (std::uint32_t i = 1; i <= shardCount; ++i)
waitShard(*db, i);
auto const finalShards{std::move(db->getShardInfo()->finalized())};
auto const finalShards{db->getShardInfo()->finalized()};
for (std::uint32_t shardIndex : {1, 2, 3, 4})
BEAST_EXPECT(boost::icl::contains(finalShards, shardIndex));