ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-12-06 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(PathRequest): remove incorrect assert (#4743)

Browse Source 
The assert is saying that the only reason `pathFinder` would be null is
if the request was aborted (connection dropped, etc.). That's what
`continueCallback()` checks. But that is very clearly not true if you
look at `getPathFinder`, which calls `findPaths`, which can return false
for many reasons.

Fix #4744
This commit is contained in:
Ed Hennis
2023-10-12 13:10:35 -04:00
committed by tequ
parent bcfb37bc5c
commit c1c2a9b3a6
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/ripple/app/paths/PathRequest.cpp
View File

@@ -538,7 +538,6 @@ PathRequest::findPaths(
continueCallback); continueCallback);
if (!pathfinder) if (!pathfinder)
{ {
assert(continueCallback && !continueCallback());
JLOG(m_journal.debug()) << iIdentifier << " No paths found"; JLOG(m_journal.debug()) << iIdentifier << " No paths found";
continue; continue;
} }