From bf3d3b7535b9aef8773039509742acaa58378e35 Mon Sep 17 00:00:00 2001 From: Vinnie Falco Date: Tue, 23 Jul 2013 16:37:09 -0700 Subject: [PATCH] Add missing virtual dtors --- TODO.txt | 7 +------ modules/ripple_net/basics/ripple_RPCServer.h | 2 ++ src/cpp/ripple/NetworkOPs.h | 2 ++ 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/TODO.txt b/TODO.txt index 69e5eda3d..3b1db72dd 100644 --- a/TODO.txt +++ b/TODO.txt @@ -4,20 +4,15 @@ RIPPLE TODO Items marked '*' can be handled by third parties. - Vinnie's Short List (Changes day to day) - Make theConfig a SharedSingleton to prevent leak warnings -- Add fast backend to the unit test - Refactor Section code into ConfigFile -- Change NodeStore config file format to multiline key/value pairs - Improved Mutex to track deadlocks -- Memory NodeStore::Backend for unit tests [*] - Finish unit tests and code for Validators - Import beast::db and use it in SQliteBackend -- Convert some Ripple boost unit tests to Beast. [*] +* Convert some Ripple boost unit tests to Beast. - Move all code into modules/ - Work on KeyvaDB -[*] These can be handled by external developers -------------------------------------------------------------------------------- diff --git a/modules/ripple_net/basics/ripple_RPCServer.h b/modules/ripple_net/basics/ripple_RPCServer.h index 1290180ec..f652678b4 100644 --- a/modules/ripple_net/basics/ripple_RPCServer.h +++ b/modules/ripple_net/basics/ripple_RPCServer.h @@ -47,6 +47,8 @@ public: boost::asio::ssl::context& context, Handler& handler); + virtual ~RPCServer () { } + /** Called when the connection is established. */ virtual void connected () = 0; diff --git a/src/cpp/ripple/NetworkOPs.h b/src/cpp/ripple/NetworkOPs.h index d5aebcb7d..9381ffb39 100644 --- a/src/cpp/ripple/NetworkOPs.h +++ b/src/cpp/ripple/NetworkOPs.h @@ -58,6 +58,8 @@ public: // explicit NetworkOPs (LedgerMaster* pLedgerMaster); + virtual ~NetworkOPs () { } + // network information uint32 getNetworkTimeNC (); // Our best estimate of wall time in seconds from 1/1/2000 uint32 getCloseTimeNC (); // Our best estimate of current ledger close time