From aeece150962987950ef856983cb2bf9c52942baa Mon Sep 17 00:00:00 2001 From: Denis Angell Date: Mon, 3 Mar 2025 09:55:51 +0100 Subject: [PATCH 1/2] [fix] github runner (#451) Co-authored-by: Niq Dudfield --- build-core.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-core.sh b/build-core.sh index be73bd348..f2a4a2368 100755 --- a/build-core.sh +++ b/build-core.sh @@ -30,7 +30,7 @@ fi perl -i -pe "s/^(\\s*)-DBUILD_SHARED_LIBS=OFF/\\1-DBUILD_SHARED_LIBS=OFF\\n\\1-DROCKSDB_BUILD_SHARED=OFF/g" Builds/CMake/deps/Rocksdb.cmake && mv Builds/CMake/deps/WasmEdge.cmake Builds/CMake/deps/WasmEdge.old && echo "find_package(LLVM REQUIRED CONFIG) -message(STATUS \"Found LLVM ${LLVM_PACKAGE_VERSION}\") +message(STATUS \"Found LLVM \${LLVM_PACKAGE_VERSION}\") message(STATUS \"Using LLVMConfig.cmake in: \${LLVM_DIR}\") add_library (wasmedge STATIC IMPORTED GLOBAL) set_target_properties(wasmedge PROPERTIES IMPORTED_LOCATION \${WasmEdge_LIB}) From 88b01514c19f62ba8de89b0b9d84527f0cb04b59 Mon Sep 17 00:00:00 2001 From: Niq Dudfield Date: Mon, 3 Mar 2025 19:12:13 +0700 Subject: [PATCH 2/2] fix: remove negative rate test failing on MacOS (#452) --- src/test/app/Remit_test.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/test/app/Remit_test.cpp b/src/test/app/Remit_test.cpp index ac527c9db..8b615960f 100644 --- a/src/test/app/Remit_test.cpp +++ b/src/test/app/Remit_test.cpp @@ -2102,9 +2102,10 @@ struct Remit_test : public beast::unit_test::suite std::string result; TER code; }; - std::array testCases = {{ + // We test only rates that that can fit in a STI_UINT32. + // Negative rates can't be serdes so there is no need to test them. + std::array testCases = {{ {0.0, USD(100), "900", tesSUCCESS}, - {-1.0, USD(100), "900", temBAD_TRANSFER_RATE}, {0.9, USD(100), "900", temBAD_TRANSFER_RATE}, {1.0, USD(100), "900", tesSUCCESS}, {1.1, USD(100), "890", tesSUCCESS},