ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-12-06 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Strict input validation against expected schema (RIPD-1709, RIPD-1710)

Browse Source
This commit is contained in:
Joseph Busch
2018-12-20 13:27:23 -06:00
committed by Nik Bougalis
parent 1be8094ee2
commit ba9ca1378e
1 changed files with 29 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/ripple/rpc/impl/ServerHandlerImp.cpp
View File

@@ -599,6 +599,16 @@ ServerHandlerImp::processRequest (Port const& port,
{
Json::Value const& jsonRPC =
batch ? jsonOrig[jss::params][i] : jsonOrig;
if (!jsonRPC.isObject())
{
Json::Value r(Json::objectValue);
r[jss::request] = jsonRPC;
r[jss::error] = make_json_error(method_not_found, "Method not found");
reply.append(r);
continue;
}
/* ------------------------------------------------------------------ */
auto role = Role::FORBID;
auto required = Role::FORBID;
@@ -740,8 +750,26 @@ ServerHandlerImp::processRequest (Port const& port,
}
std::string ripplerpc = "1.0";
if (params.isMember(jss::ripplerpc) && params[jss::ripplerpc] != "1.0")
if (params.isMember(jss::ripplerpc))
{
if (!params[jss::ripplerpc].isString())
{
usage.charge(Resource::feeInvalidRPC);
if (!batch)
{
HTTPReply(400, "ripplerpc is not a string", output, rpcJ);
return;
}
Json::Value r = jsonRPC;
r[jss::error] = make_json_error(
method_not_found, "ripplerpc is not a string");
reply.append(r);
continue;
}
ripplerpc = params[jss::ripplerpc].asString();
}
/**
* Clear header-assigned values if not positively identified from a
* secure_gateway.