diff --git a/Builds/VisualStudio2015/RippleD.vcxproj b/Builds/VisualStudio2015/RippleD.vcxproj
index 97fe36854..a2df62585 100644
--- a/Builds/VisualStudio2015/RippleD.vcxproj
+++ b/Builds/VisualStudio2015/RippleD.vcxproj
@@ -1411,10 +1411,6 @@
True
True
-
- True
- True
-
True
True
@@ -1463,8 +1459,6 @@
-
-
@@ -2114,8 +2108,6 @@
-
-
@@ -2258,8 +2250,6 @@
-
-
@@ -3040,8 +3030,6 @@
-
-
@@ -3132,208 +3120,8 @@
-
-
-
-
-
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
- True
- True
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- True
- True
-
-
-
-
-
True
True
@@ -3460,10 +3248,6 @@
..\..\src\soci\include\private;..\..\src\soci\src\core;..\..\src\sqlite;%(AdditionalIncludeDirectories)
..\..\src\soci\include\private;..\..\src\soci\src\core;..\..\src\sqlite;%(AdditionalIncludeDirectories)
-
- True
- True
-
@@ -4448,10 +4232,6 @@
True
True
-
- True
- True
-
True
True
@@ -4557,16 +4337,20 @@
True
- True
+ True
+ True
- True
+ True
+ True
- True
+ True
+ True
- True
+ True
+ True
True
@@ -4592,10 +4376,6 @@
True
True
-
- True
- True
-
True
True
@@ -4608,6 +4388,8 @@
True
True
+
+
True
True
@@ -4664,6 +4446,8 @@
..\..\src\rocksdb2\include;..\..\src\snappy\config;..\..\src\snappy\snappy;%(AdditionalIncludeDirectories)
..\..\src\rocksdb2\include;..\..\src\snappy\config;..\..\src\snappy\snappy;%(AdditionalIncludeDirectories)
+
+
True
True
@@ -4844,6 +4628,8 @@
True
True
+
+
True
True
@@ -4856,73 +4642,283 @@
True
True
-
+
+
+
+
+
True
True
-
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+ True
+ True
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ True
+ True
+
+
+
+
+
+
+
+
+
+
+ True
+ True
+
+
True
True
-
+
True
True
-
+
True
True
-
+
True
True
-
+
True
True
-
+
True
True
-
+
True
True
-
+
True
True
..\..\src\rocksdb2\include;..\..\src\snappy\config;..\..\src\snappy\snappy;%(AdditionalIncludeDirectories)
..\..\src\rocksdb2\include;..\..\src\snappy\config;..\..\src\snappy\snappy;%(AdditionalIncludeDirectories)
-
+
True
True
-
+
True
True
-
+
True
True
-
+
True
True
-
+
True
True
-
+
True
True
-
+
True
True
-
+
True
True
diff --git a/Builds/VisualStudio2015/RippleD.vcxproj.filters b/Builds/VisualStudio2015/RippleD.vcxproj.filters
index f7bf7fa95..831951294 100644
--- a/Builds/VisualStudio2015/RippleD.vcxproj.filters
+++ b/Builds/VisualStudio2015/RippleD.vcxproj.filters
@@ -229,9 +229,6 @@
{EA35E0D0-6876-9DC8-10FA-1E6A0486C574}
-
- {D5A85FA6-148D-DA25-5DAA-C59504C18F26}
-
{6649BD29-BE86-723F-501A-045E39310112}
@@ -247,9 +244,6 @@
{9D691DE1-17A1-5989-3E2E-F69B3E43152F}
-
- {3FDC73B9-A9C7-3533-FD40-E4032B9FA9FB}
-
{51E817F6-DC2E-045A-9009-37E3D16D0990}
@@ -289,9 +283,6 @@
{93AC3675-D183-4DB4-021E-8F4CA1586866}
-
- {84FF17C5-6A81-FF13-548E-59940FE0060E}
-
{8A61DBF7-69CB-9043-8312-D44C40EC6AE9}
@@ -304,27 +295,6 @@
{92AC870A-6B4B-9CD5-4F7F-648C72CFA0D3}
-
- {F0AEA72D-7030-C8C7-1E34-1029BBD56886}
-
-
- {B25F5854-84AE-1CBD-DFFC-6515DD055652}
-
-
- {CF7F0C3F-3D61-7764-BA8B-5FF38018425C}
-
-
- {A21A3B94-5C44-3746-4F10-6FF8FF990CE3}
-
-
- {27D70888-7145-691C-0E0A-E511EB3A80A2}
-
-
- {94B5035A-6D4A-E4FC-DB50-E7E804DC9F13}
-
-
- {23DE6C05-81D2-7471-D9BB-3AA1D49DE429}
-
{5DB3CD0B-B361-B301-9562-697CA8A52B68}
@@ -493,8 +463,26 @@
{2E37F2EA-49FC-1F02-C3EA-D7EB608603A1}
-
- {82E1AA93-0E6B-39FA-4212-EB820AD49028}
+
+ {EAFC737C-277F-7D41-3A99-8B752EB7D534}
+
+
+ {3195322A-2CFC-904C-A6AA-1B60F8E5490D}
+
+
+ {E6B36A4D-232C-FA63-7B5A-24ADE91F0F32}
+
+
+ {F9870E4C-E01C-B734-1475-92401F8766BF}
+
+
+ {52F836F7-261B-9EA5-8DC4-02E4B010F4D3}
+
+
+ {2AB83499-A4F2-EDED-BC79-6DC296EE9D8A}
+
+
+ {4FD99791-5191-0BFF-8D77-19500238E44E}
@@ -1911,9 +1899,6 @@
ripple\basics\impl
-
- ripple\basics\impl
-
ripple\basics\impl
@@ -1977,9 +1962,6 @@
ripple\basics
-
- ripple\basics
-
ripple\basics
@@ -2703,9 +2685,6 @@
ripple\ledger
-
- ripple\ledger\tests
-
ripple\ledger
@@ -2832,9 +2811,6 @@
ripple\nodestore
-
- ripple\nodestore\tests
-
ripple\nodestore
@@ -3603,9 +3579,6 @@
ripple\rpc
-
- ripple\rpc\tests
-
ripple\server
@@ -3714,222 +3687,9 @@
ripple\shamap
-
- ripple\shamap\tests
-
ripple\shamap
-
- ripple\test
-
-
- ripple\test
-
-
- ripple\test\impl
-
-
- ripple\test\impl
-
-
- ripple\test\impl
-
-
- ripple\test
-
-
- ripple\test
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx\impl
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test\jtx
-
-
- ripple\test
-
-
- ripple\test\mao\impl
-
-
- ripple\test\mao
-
-
- ripple\test
-
ripple\unity
@@ -4023,9 +3783,6 @@
ripple\unity
-
- ripple\unity
-
ripple\websocket
@@ -5214,9 +4971,6 @@
test\app
-
- test
-
test\basics
@@ -5325,9 +5079,6 @@
test\core
-
- test
-
test\json
@@ -5337,6 +5088,9 @@
test\json
+
+ test\json
+
test\json
@@ -5373,6 +5127,9 @@
test\nodestore
+
+ test\nodestore
+
test\nodestore
@@ -5505,6 +5262,9 @@
test\server
+
+ test\shamap
+
test\shamap
@@ -5514,56 +5274,278 @@
test\shamap
-
- test
+
+ test\support
+
+
+ test\support
+
+
+ test\support
-
- unity
+
+ test\support
-
- unity
+
+ test\support\impl
-
- unity
+
+ test\support\impl
-
- unity
+
+ test\support\impl
-
- unity
+
+ test\support
+
+
+ test\support
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx\impl
-
- unity
+
+ test\support\jtx\impl
-
- unity
+
+ test\support\jtx\impl
-
- unity
+
+ test\support\jtx\impl
-
- unity
+
+ test\support\jtx\impl
-
- unity
+
+ test\support\jtx\impl
-
- unity
+
+ test\support\jtx\impl
-
- unity
+
+ test\support\jtx\impl
-
- unity
+
+ test\support\jtx\impl
-
- unity
+
+ test\support\jtx\impl
-
- unity
+
+ test\support\jtx\impl
-
- unity
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx\impl
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support\jtx
+
+
+ test\support
+
+
+ test\support\mao\impl
+
+
+ test\support\mao
+
+
+ test\support
+
+
+ test\support
+
+
+ test\support
+
+
+ test\support
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
+
+
+ test\unity
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 7a48d69e9..89780725d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -195,11 +195,10 @@ json.cpp
protocol.cpp
rpcx.cpp
shamap.cpp
-server.cpp
-test.cpp)
+server.cpp)
prepend(test_unity_srcs
-src/unity/
+src/test/unity/
app_test_unity.cpp
basics_test_unity.cpp
beast_test_unity.cpp
@@ -214,11 +213,11 @@ resource_test_unity.cpp
rpc_test_unity.cpp
server_test_unity.cpp
shamap_test_unity.cpp
-test_unity.cpp)
+support_unity.cpp)
list(APPEND rippled_src_unity ${beast_unity_srcs} ${ripple_unity_srcs} ${test_unity_srcs})
-add_with_props(rippled_src_unity src/unity/nodestore_test_unity.cpp
+add_with_props(rippled_src_unity src/test/unity/nodestore_test_unity.cpp
-I"${CMAKE_SOURCE_DIR}/"src/rocksdb2/include
-I"${CMAKE_SOURCE_DIR}/"src/snappy/snappy
-I"${CMAKE_SOURCE_DIR}/"src/snappy/config
@@ -235,7 +234,7 @@ add_with_props(rippled_src_unity src/ripple/unity/soci_ripple.cpp ${soci_extra_i
list(APPEND ripple_unity_srcs ${beast_unity_srcs} ${test_unity_srcs}
src/ripple/unity/nodestore.cpp
src/ripple/unity/soci_ripple.cpp
-src/unity/nodestore_test_unity.cpp)
+src/test/unity/nodestore_test_unity.cpp)
############################################################
@@ -266,8 +265,7 @@ foreach(curdir
protocol
rpc
server
- shamap
- test)
+ shamap)
file(GLOB_RECURSE cursrcs src/ripple/${curdir}/*.cpp)
list(APPEND rippled_src_nonunity "${cursrcs}")
list(APPEND non_unity_srcs "${cursrcs}")
@@ -284,7 +282,28 @@ add_with_props(rippled_src_nonunity "${nodestore_srcs}"
list(APPEND non_unity_srcs "${nodestore_srcs}")
-file(GLOB_RECURSE test_srcs src/test/*.cpp)
+# unit test sources
+foreach(curdir
+ app
+ basics
+ beast
+ conditions
+ core
+ json
+ ledger
+ nodestore
+ overlay
+ peerfinder
+ protocol
+ resource
+ rpc
+ server
+ shamap
+ support)
+ file(GLOB_RECURSE cursrcs src/test/${curdir}/*.cpp)
+ list(APPEND test_srcs "${cursrcs}")
+endforeach()
+
add_with_props(rippled_src_nonunity "${test_srcs}"
-I"${CMAKE_SOURCE_DIR}/"src/rocksdb2/include
-I"${CMAKE_SOURCE_DIR}/"src/snappy/snappy
diff --git a/SConstruct b/SConstruct
index c45fe3dc0..724ec2b47 100644
--- a/SConstruct
+++ b/SConstruct
@@ -949,14 +949,10 @@ def get_classic_sources(toolchain):
append_sources(result, *list_sources('src/ripple/rpc', '.cpp'))
append_sources(result, *list_sources('src/ripple/shamap', '.cpp'))
append_sources(result, *list_sources('src/ripple/server', '.cpp'))
- append_sources(result, *list_sources('src/ripple/test', '.cpp'))
- append_sources(result,
- 'src/test/BasicNetwork_test.cpp',
- 'src/test/Env_test.cpp',
- 'src/test/WSClient_test.cpp')
append_sources(result, *list_sources('src/test/app', '.cpp'))
append_sources(result, *list_sources('src/test/basics', '.cpp'))
append_sources(result, *list_sources('src/test/beast', '.cpp'))
+ append_sources(result, *list_sources('src/test/conditions', '.cpp'))
append_sources(result, *list_sources('src/test/core', '.cpp'))
append_sources(result, *list_sources('src/test/json', '.cpp'))
append_sources(result, *list_sources('src/test/ledger', '.cpp'))
@@ -967,6 +963,8 @@ def get_classic_sources(toolchain):
append_sources(result, *list_sources('src/test/rpc', '.cpp'))
append_sources(result, *list_sources('src/test/server', '.cpp'))
append_sources(result, *list_sources('src/test/shamap', '.cpp'))
+ append_sources(result, *list_sources('src/test/support', '.cpp'))
+
if use_shp(toolchain):
cc_flags = {'CCFLAGS': ['--system-header-prefix=rocksdb2']}
@@ -1013,22 +1011,21 @@ def get_unity_sources(toolchain):
'src/ripple/unity/rpcx.cpp',
'src/ripple/unity/shamap.cpp',
'src/ripple/unity/server.cpp',
- 'src/ripple/unity/test.cpp',
- 'src/unity/app_test_unity.cpp',
- 'src/unity/basics_test_unity.cpp',
- 'src/unity/beast_test_unity.cpp',
- 'src/unity/core_test_unity.cpp',
- 'src/unity/conditions_test_unity.cpp',
- 'src/unity/json_test_unity.cpp',
- 'src/unity/ledger_test_unity.cpp',
- 'src/unity/overlay_test_unity.cpp',
- 'src/unity/peerfinder_test_unity.cpp',
- 'src/unity/protocol_test_unity.cpp',
- 'src/unity/resource_test_unity.cpp',
- 'src/unity/rpc_test_unity.cpp',
- 'src/unity/server_test_unity.cpp',
- 'src/unity/shamap_test_unity.cpp',
- 'src/unity/test_unity.cpp'
+ 'src/test/unity/app_test_unity.cpp',
+ 'src/test/unity/basics_test_unity.cpp',
+ 'src/test/unity/beast_test_unity.cpp',
+ 'src/test/unity/core_test_unity.cpp',
+ 'src/test/unity/conditions_test_unity.cpp',
+ 'src/test/unity/json_test_unity.cpp',
+ 'src/test/unity/ledger_test_unity.cpp',
+ 'src/test/unity/overlay_test_unity.cpp',
+ 'src/test/unity/peerfinder_test_unity.cpp',
+ 'src/test/unity/protocol_test_unity.cpp',
+ 'src/test/unity/resource_test_unity.cpp',
+ 'src/test/unity/rpc_test_unity.cpp',
+ 'src/test/unity/server_test_unity.cpp',
+ 'src/test/unity/shamap_test_unity.cpp',
+ 'src/test/unity/support_unity.cpp'
)
if use_shp(toolchain):
@@ -1039,7 +1036,7 @@ def get_unity_sources(toolchain):
append_sources(
result,
'src/ripple/unity/nodestore.cpp',
- 'src/unity/nodestore_test_unity.cpp',
+ 'src/test/unity/nodestore_test_unity.cpp',
CPPPATH=[
'src/rocksdb2/include',
'src/snappy/snappy',
@@ -1274,10 +1271,10 @@ def do_count(target, source, env):
path = os.path.join(parent, path)
r = os.path.splitext(path)
if r[1] in suffixes:
- if r[0].endswith('.test'):
+ if r[0].endswith('_test'):
yield os.path.normpath(path)
return list(_iter(base))
- testfiles = list_testfiles(os.path.join('src', 'ripple'), env.get('CPPSUFFIXES'))
+ testfiles = list_testfiles(os.path.join('src', 'test'), env.get('CPPSUFFIXES'))
lines = 0
for f in testfiles:
lines = lines + sum(1 for line in open(f))
diff --git a/bin/ci/ubuntu/build-and-test.sh b/bin/ci/ubuntu/build-and-test.sh
index ab101260d..09e69bed6 100755
--- a/bin/ci/ubuntu/build-and-test.sh
+++ b/bin/ci/ubuntu/build-and-test.sh
@@ -46,8 +46,8 @@ if [[ ${APP} == "rippled" ]]; then
export APP_ARGS="--unittest"
# Only report on src/ripple files
export LCOV_FILES="*/src/ripple/*"
- # Exclude */src/ripple/test directory
- export LCOV_EXCLUDE_FILES="*/src/ripple/test/*"
+ # Nothing to explicitly exclude
+ export LCOV_EXCLUDE_FILES="LCOV_NO_EXCLUDE"
else
: ${APP_ARGS:=}
: ${LCOV_FILES:="*/src/*"}
diff --git a/src/ripple/app/ledger/Ledger.cpp b/src/ripple/app/ledger/Ledger.cpp
index f97a7da6f..ba921ecea 100644
--- a/src/ripple/app/ledger/Ledger.cpp
+++ b/src/ripple/app/ledger/Ledger.cpp
@@ -48,7 +48,6 @@
#include
#include
#include
-#include
#include
#include
#include
diff --git a/src/ripple/app/main/Main.cpp b/src/ripple/app/main/Main.cpp
index 647dad504..6ad534b40 100644
--- a/src/ripple/app/main/Main.cpp
+++ b/src/ripple/app/main/Main.cpp
@@ -38,9 +38,11 @@
#include
#include
#include
-#include
#include
#include
+#include
+#include
+#include
#include
#include
#include
diff --git a/src/ripple/basics/impl/CheckLibraryVersions.cpp b/src/ripple/basics/impl/CheckLibraryVersions.cpp
index 5009ccdfd..b4268ba78 100644
--- a/src/ripple/basics/impl/CheckLibraryVersions.cpp
+++ b/src/ripple/basics/impl/CheckLibraryVersions.cpp
@@ -20,7 +20,6 @@
#include
#include
#include
-#include
#include
#include
#include
diff --git a/src/ripple/basics/impl/RangeSet.cpp b/src/ripple/basics/impl/RangeSet.cpp
index ffd3bdd85..ed13d5349 100644
--- a/src/ripple/basics/impl/RangeSet.cpp
+++ b/src/ripple/basics/impl/RangeSet.cpp
@@ -20,7 +20,6 @@
#include
#include
#include
-#include
#include
#include
#include
diff --git a/src/ripple/basics/impl/StringUtilities.cpp b/src/ripple/basics/impl/StringUtilities.cpp
index 44f115fdb..6de1bb03d 100644
--- a/src/ripple/basics/impl/StringUtilities.cpp
+++ b/src/ripple/basics/impl/StringUtilities.cpp
@@ -23,7 +23,6 @@
#include
#include
#include
-#include
#include
#include
#include
diff --git a/src/ripple/basics/impl/TestSuite.test.cpp b/src/ripple/basics/impl/TestSuite.test.cpp
deleted file mode 100644
index 741680b53..000000000
--- a/src/ripple/basics/impl/TestSuite.test.cpp
+++ /dev/null
@@ -1,39 +0,0 @@
-//------------------------------------------------------------------------------
-/*
- This file is part of rippled: https://github.com/ripple/rippled
- Copyright (c) 2012, 2013 Ripple Labs Inc.
-
- Permission to use, copy, modify, and/or distribute this software for any
- purpose with or without fee is hereby granted, provided that the above
- copyright notice and this permission notice appear in all copies.
-
- THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- ANY SPECIAL , DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
-*/
-//==============================================================================
-
-#include
-#include
-
-namespace ripple {
-
-struct TestSuite_test : TestSuite
-{
- void run() override
- {
- expectEquals (2, 2, "this won't get printed.");
- using Vec = std::vector;
- Vec v1{"hello", "world"};
- Vec v2{"hello", "world"};
- expectCollectionEquals (v1, v2, "this won't get printed.");
-
- // TODO(tom): how to test failure?
- }
-};
-
-} // ripple
diff --git a/src/ripple/json/impl/Writer.cpp b/src/ripple/json/impl/Writer.cpp
index 9a8a47d83..5b2f1f610 100644
--- a/src/ripple/json/impl/Writer.cpp
+++ b/src/ripple/json/impl/Writer.cpp
@@ -20,8 +20,8 @@
#include
#include
#include
-#include
#include
+#include
namespace Json {
diff --git a/src/ripple/protocol/impl/BuildInfo.cpp b/src/ripple/protocol/impl/BuildInfo.cpp
index 23ae1f394..d5a5a8095 100644
--- a/src/ripple/protocol/impl/BuildInfo.cpp
+++ b/src/ripple/protocol/impl/BuildInfo.cpp
@@ -19,7 +19,6 @@
#include
#include
-#include
#include
#include
diff --git a/src/ripple/protocol/impl/STTx.cpp b/src/ripple/protocol/impl/STTx.cpp
index 4aea634eb..3a92127e1 100644
--- a/src/ripple/protocol/impl/STTx.cpp
+++ b/src/ripple/protocol/impl/STTx.cpp
@@ -32,7 +32,6 @@
#include
#include
#include
-#include
#include
#include
#include
diff --git a/src/ripple/shamap/impl/SHAMap.cpp b/src/ripple/shamap/impl/SHAMap.cpp
index c329b78d6..4a28da611 100644
--- a/src/ripple/shamap/impl/SHAMap.cpp
+++ b/src/ripple/shamap/impl/SHAMap.cpp
@@ -20,7 +20,6 @@
#include
#include
#include
-#include
namespace ripple {
diff --git a/src/ripple/shamap/impl/SHAMapSync.cpp b/src/ripple/shamap/impl/SHAMapSync.cpp
index 669d868a2..313ed9057 100644
--- a/src/ripple/shamap/impl/SHAMapSync.cpp
+++ b/src/ripple/shamap/impl/SHAMapSync.cpp
@@ -21,7 +21,6 @@
#include
#include
#include
-#include
namespace ripple {
diff --git a/src/ripple/unity/basics.cpp b/src/ripple/unity/basics.cpp
index 561a4c390..8903eb5b4 100644
--- a/src/ripple/unity/basics.cpp
+++ b/src/ripple/unity/basics.cpp
@@ -31,7 +31,6 @@
#include
#include
#include
-#include
#include
#include
#include
diff --git a/src/ripple/unity/test.cpp b/src/ripple/unity/test.cpp
deleted file mode 100644
index 8168d5b9c..000000000
--- a/src/ripple/unity/test.cpp
+++ /dev/null
@@ -1,51 +0,0 @@
-//------------------------------------------------------------------------------
-/*
- This file is part of rippled: https://github.com/ripple/rippled
- Copyright (c) 2012, 2013 Ripple Labs Inc.
-
- Permission to use, copy, modify, and/or distribute this software for any
- purpose with or without fee is hereby granted, provided that the above
- copyright notice and this permission notice appear in all copies.
-
- THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
- WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
- MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
- ANY SPECIAL , DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
- WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
- ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
- OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
-*/
-//==============================================================================
-
-#include
-
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-
-#include
-#include
-#include
-#include
diff --git a/src/test/app/AccountTxPaging_test.cpp b/src/test/app/AccountTxPaging_test.cpp
index 0a744deab..dc1662223 100644
--- a/src/test/app/AccountTxPaging_test.cpp
+++ b/src/test/app/AccountTxPaging_test.cpp
@@ -19,7 +19,7 @@
#include
#include
#include
-#include
+#include
#include
#include
#include
diff --git a/src/test/app/CrossingLimits_test.cpp b/src/test/app/CrossingLimits_test.cpp
index e33f520ad..5b1590886 100644
--- a/src/test/app/CrossingLimits_test.cpp
+++ b/src/test/app/CrossingLimits_test.cpp
@@ -16,7 +16,7 @@
//==============================================================================
#include
-#include
+#include
#include
namespace ripple {
diff --git a/src/test/app/DeliverMin_test.cpp b/src/test/app/DeliverMin_test.cpp
index bb74ea290..c38bef053 100644
--- a/src/test/app/DeliverMin_test.cpp
+++ b/src/test/app/DeliverMin_test.cpp
@@ -18,7 +18,7 @@
//==============================================================================
#include
-#include
+#include
#include
namespace ripple {
diff --git a/src/test/app/Discrepancy_test.cpp b/src/test/app/Discrepancy_test.cpp
index cff6c5952..470334ee2 100644
--- a/src/test/app/Discrepancy_test.cpp
+++ b/src/test/app/Discrepancy_test.cpp
@@ -18,8 +18,8 @@
//==============================================================================
#include
-#include
-#include
+#include
+#include
#include
#include
#include
diff --git a/src/test/app/Flow_test.cpp b/src/test/app/Flow_test.cpp
index 0b5e49291..0f42a6d4c 100644
--- a/src/test/app/Flow_test.cpp
+++ b/src/test/app/Flow_test.cpp
@@ -16,14 +16,14 @@
//==============================================================================
#include
-#include
+#include
#include
#include
#include
#include
#include
#include
-#include
+#include
#include
#include
namespace ripple {
diff --git a/src/test/app/Freeze_test.cpp b/src/test/app/Freeze_test.cpp
index b80ad2852..6c4b0ad33 100644
--- a/src/test/app/Freeze_test.cpp
+++ b/src/test/app/Freeze_test.cpp
@@ -16,7 +16,7 @@
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
//==============================================================================
-#include
+#include
#include
#include
#include
diff --git a/src/test/app/MultiSign_test.cpp b/src/test/app/MultiSign_test.cpp
index 8ef4c3b6b..28c092f5e 100644
--- a/src/test/app/MultiSign_test.cpp
+++ b/src/test/app/MultiSign_test.cpp
@@ -18,7 +18,7 @@
#include
#include // jss:: definitions
#include
-#include
+#include
namespace ripple {
namespace test {
diff --git a/src/test/app/Offer_test.cpp b/src/test/app/Offer_test.cpp
index bed353087..53b24b9ff 100644
--- a/src/test/app/Offer_test.cpp
+++ b/src/test/app/Offer_test.cpp
@@ -18,9 +18,9 @@
//==============================================================================
#include
-#include
-#include
-#include
+#include
+#include
+#include
#include
#include
#include
diff --git a/src/test/app/OversizeMeta_test.cpp b/src/test/app/OversizeMeta_test.cpp
index 7a5998e79..f3b5e0e3a 100644
--- a/src/test/app/OversizeMeta_test.cpp
+++ b/src/test/app/OversizeMeta_test.cpp
@@ -18,7 +18,7 @@
//==============================================================================
#include
-#include
+#include
#include
#include
diff --git a/src/test/app/Path_test.cpp b/src/test/app/Path_test.cpp
index a39120390..9682f7754 100644
--- a/src/test/app/Path_test.cpp
+++ b/src/test/app/Path_test.cpp
@@ -30,7 +30,7 @@
#include
#include
#include
-#include
+#include
#include
#include
#include
diff --git a/src/test/app/PayChan_test.cpp b/src/test/app/PayChan_test.cpp
index d9b667c3c..69b3ba421 100644
--- a/src/test/app/PayChan_test.cpp
+++ b/src/test/app/PayChan_test.cpp
@@ -24,7 +24,7 @@
#include
#include
#include
-#include
+#include
#include
diff --git a/src/test/app/Regression_test.cpp b/src/test/app/Regression_test.cpp
index 116783a88..c06769eb4 100644
--- a/src/test/app/Regression_test.cpp
+++ b/src/test/app/Regression_test.cpp
@@ -16,7 +16,7 @@
//==============================================================================
#include
-#include
+#include
#include
#include
#include
diff --git a/src/test/app/SHAMapStore_test.cpp b/src/test/app/SHAMapStore_test.cpp
index fb9b485fd..6db40a4dc 100644
--- a/src/test/app/SHAMapStore_test.cpp
+++ b/src/test/app/SHAMapStore_test.cpp
@@ -24,7 +24,7 @@
#include
#include
#include
-#include
+#include
namespace ripple {
namespace test {
diff --git a/src/test/app/SetAuth_test.cpp b/src/test/app/SetAuth_test.cpp
index 57ef5aba4..4374b0638 100644
--- a/src/test/app/SetAuth_test.cpp
+++ b/src/test/app/SetAuth_test.cpp
@@ -18,7 +18,7 @@
//==============================================================================
#include
-#include
+#include
#include
#include
diff --git a/src/test/app/SetRegularKey_test.cpp b/src/test/app/SetRegularKey_test.cpp
index 691037bb9..1538b3312 100644
--- a/src/test/app/SetRegularKey_test.cpp
+++ b/src/test/app/SetRegularKey_test.cpp
@@ -19,7 +19,7 @@
#include
#include
-#include
+#include
namespace ripple {
diff --git a/src/test/app/SetTrust_test.cpp b/src/test/app/SetTrust_test.cpp
index 9eb3667c9..c1137a14f 100644
--- a/src/test/app/SetTrust_test.cpp
+++ b/src/test/app/SetTrust_test.cpp
@@ -16,7 +16,7 @@
OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/
//==============================================================================
-#include
+#include
#include
#include
diff --git a/src/test/app/SusPay_test.cpp b/src/test/app/SusPay_test.cpp
index efb348839..941590453 100644
--- a/src/test/app/SusPay_test.cpp
+++ b/src/test/app/SusPay_test.cpp
@@ -18,7 +18,7 @@
//==============================================================================
#include
-#include
+#include
#include
#include
#include
diff --git a/src/test/app/Ticket_test.cpp b/src/test/app/Ticket_test.cpp
index fcacba35a..6c8b157c5 100644
--- a/src/test/app/Ticket_test.cpp
+++ b/src/test/app/Ticket_test.cpp
@@ -18,7 +18,7 @@
//==============================================================================
#include
-#include
+#include
#include
#include
diff --git a/src/test/app/Transaction_ordering_test.cpp b/src/test/app/Transaction_ordering_test.cpp
index 0d40afc9a..99c45f802 100644
--- a/src/test/app/Transaction_ordering_test.cpp
+++ b/src/test/app/Transaction_ordering_test.cpp
@@ -18,7 +18,7 @@
#include
#include
#include
-#include
+#include
namespace ripple {
namespace test {
diff --git a/src/test/app/TrustAndBalance_test.cpp b/src/test/app/TrustAndBalance_test.cpp
index 7d0071d85..4e32c55ce 100644
--- a/src/test/app/TrustAndBalance_test.cpp
+++ b/src/test/app/TrustAndBalance_test.cpp
@@ -18,11 +18,11 @@
//==============================================================================
#include
-#include
+#include
#include
#include
#include
-#include
+#include
namespace ripple {
diff --git a/src/test/app/TxQ_test.cpp b/src/test/app/TxQ_test.cpp
index b5e5d46ec..01cc5bf7f 100644
--- a/src/test/app/TxQ_test.cpp
+++ b/src/test/app/TxQ_test.cpp
@@ -24,13 +24,13 @@
#include
#include
#include
-#include
+#include
#include
#include