From aa9b03e57bc9f9ca62488c79a313698d2febccb0 Mon Sep 17 00:00:00 2001
From: Richard Holland <richard.holland@starstone.co.nz>
Date: Fri, 17 Feb 2023 12:29:46 +0000
Subject: [PATCH] fix for #16

---
 src/ripple/app/hook/impl/applyHook.cpp | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/ripple/app/hook/impl/applyHook.cpp b/src/ripple/app/hook/impl/applyHook.cpp
index f8b1ccc8c..810701d9d 100644
--- a/src/ripple/app/hook/impl/applyHook.cpp
+++ b/src/ripple/app/hook/impl/applyHook.cpp
@@ -1756,10 +1756,6 @@ finalizeHookResult(
 
             std::shared_ptr<const ripple::STTx> ptr = tpTrans->getSTransaction();
 
-            ripple::Serializer s;
-            ptr->add(s);
-            SerialIter sit(s.slice());
-
             auto emittedId = keylet::emittedTxn(id);
             auto sleEmitted = applyCtx.view().peek(emittedId);
 
@@ -1767,6 +1763,12 @@ finalizeHookResult(
             {
                 ++emission_count;
                 sleEmitted = std::make_shared<SLE>(emittedId);
+
+                // RH TODO: add a new constructor to STObject to avoid this serder thing            
+                ripple::Serializer s;
+                ptr->add(s);
+                SerialIter sit(s.slice());
+
                 sleEmitted->emplace_back(
                     ripple::STObject(sit, sfEmittedTxn)
                 );