ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-12-06 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

block delete account if hooks and hook state are installed on account

Browse Source
This commit is contained in:
Richard Holland
2022-03-14 11:17:07 +00:00
parent a81f91e97a
commit a63f1ba53e
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/ripple/app/tx/impl/DeleteAccount.cpp
View File

@@ -187,6 +187,12 @@ DeleteAccount::preclaim(PreclaimContext const& ctx)
if ((*sleAccount)[sfSequence] + seqDelta > ctx.view.seq())
return tecTOO_SOON;
// do not allow the account to be removed if there are hooks installed or one or more hook states
// when these fields are completely empty the field is made absent so this test is sufficient
// these fields cannot be populated unless hooks is enabled so the rules do not need to be checked
if (sleAccount->isFieldPresent(sfHookNamespaces) || sleAccount->isFieldPresent(sfHooks))
return tecHAS_OBLIGATIONS;
// Verify that the account does not own any objects that would prevent
// the account from being deleted.
Keylet const ownerDirKeylet{keylet::ownerDir(account)};
@@ -247,6 +253,12 @@ DeleteAccount::doApply()
if (!src || !dst)
return tefBAD_LEDGER;
// do not allow the account to be removed if there are hooks installed or one or more hook states
// when these fields are completely empty the field is made absent so this test is sufficient
// these fields cannot be populated unless hooks is enabled so the rules do not need to be checked
if (src->isFieldPresent(sfHookNamespaces) || src->isFieldPresent(sfHooks))
return tecHAS_OBLIGATIONS;
// Delete all of the entries in the account directory.
Keylet const ownerDirKeylet{keylet::ownerDir(account_)};