diff --git a/src/test/app/Manifest_test.cpp b/src/test/app/Manifest_test.cpp index b6b6fdcae..0e2530041 100644 --- a/src/test/app/Manifest_test.cpp +++ b/src/test/app/Manifest_test.cpp @@ -421,51 +421,6 @@ public: getDatabasePath() / boost::filesystem::path(dbName)); } - void - testBindingID() - { - testcase("bindingID"); - - auto const sk = randomSecretKey(); - auto const kp = randomKeyPair(KeyType::secp256k1); - auto const manifest = makeManifest( - sk, KeyType::ed25519, kp.second, KeyType::secp256k1, 1); - - auto const reparsed = deserializeManifest(manifest.serialized); - BEAST_EXPECT(reparsed); - if (reparsed) - BEAST_EXPECT(manifest.bindingID() == reparsed->bindingID()); - - auto const changedSequence = makeManifest( - sk, KeyType::ed25519, kp.second, KeyType::secp256k1, 2); - BEAST_EXPECT(manifest.bindingID() != changedSequence.bindingID()); - - STObject st(sfGeneric); - SerialIter sit(manifest.serialized.data(), manifest.serialized.size()); - st.set(sit); - - auto sig = st.getFieldVL(sfSignature); - auto masterSig = st.getFieldVL(sfMasterSignature); - BEAST_EXPECT(!sig.empty()); - BEAST_EXPECT(!masterSig.empty()); - sig.front() ^= 0x01; - masterSig.front() ^= 0x01; - st.setFieldVL(sfSignature, sig); - st.setFieldVL(sfMasterSignature, masterSig); - - Serializer s; - st.add(s); - auto const alteredSignatures = deserializeManifest( - std::string(static_cast(s.data()), s.size())); - BEAST_EXPECT(alteredSignatures); - if (alteredSignatures) - { - BEAST_EXPECT( - manifest.bindingID() == alteredSignatures->bindingID()); - BEAST_EXPECT(manifest.hash() != alteredSignatures->hash()); - } - } - void testGetSignature() { @@ -1119,7 +1074,6 @@ public: } testLoadStore(cache); - testBindingID(); testGetSignature(); testGetKeys(); testValidatorToken(); diff --git a/src/xrpld/app/misc/Manifest.h b/src/xrpld/app/misc/Manifest.h index 49a747840..1b53fda77 100644 --- a/src/xrpld/app/misc/Manifest.h +++ b/src/xrpld/app/misc/Manifest.h @@ -128,10 +128,6 @@ struct Manifest uint256 hash() const; - /// Returns hash of manifest data authenticated by signatures - uint256 - bindingID() const; - /// Returns `true` if manifest revokes master key // The maximum possible sequence number means that the master key has // been revoked diff --git a/src/xrpld/app/misc/detail/Manifest.cpp b/src/xrpld/app/misc/detail/Manifest.cpp index 428fe893e..203b29298 100644 --- a/src/xrpld/app/misc/detail/Manifest.cpp +++ b/src/xrpld/app/misc/detail/Manifest.cpp @@ -209,15 +209,6 @@ Manifest::hash() const return st.getHash(HashPrefix::manifest); } -uint256 -Manifest::bindingID() const -{ - STObject st(sfGeneric); - SerialIter sit(serialized.data(), serialized.size()); - st.set(sit); - return st.getSigningHash(HashPrefix::manifest); -} - bool Manifest::revoked() const {