From 90c5bc8d245de8224603478972df5e06dcde35a2 Mon Sep 17 00:00:00 2001 From: JoelKatz Date: Tue, 9 Jul 2013 09:40:43 -0700 Subject: [PATCH] Make Transaction::save a no-op. It can destroy metadata --- src/cpp/ripple/Transaction.cpp | 37 ++-------------------------------- 1 file changed, 2 insertions(+), 35 deletions(-) diff --git a/src/cpp/ripple/Transaction.cpp b/src/cpp/ripple/Transaction.cpp index eedcafdb1..e3cc1e7c3 100644 --- a/src/cpp/ripple/Transaction.cpp +++ b/src/cpp/ripple/Transaction.cpp @@ -122,41 +122,8 @@ void Transaction::setStatus (TransStatus ts, uint32 lseq) } void Transaction::save () -{ - if ((mStatus == INVALID) || (mStatus == REMOVED)) - return; - - char status; - - switch (mStatus) - { - case NEW: - status = TXN_SQL_NEW; - break; - - case INCLUDED: - status = TXN_SQL_INCLUDED; - break; - - case CONFLICTED: - status = TXN_SQL_CONFLICT; - break; - - case COMMITTED: - status = TXN_SQL_VALIDATED; - break; - - case HELD: - status = TXN_SQL_HELD; - break; - - default: - status = TXN_SQL_UNKNOWN; - } - - Database* db = theApp->getTxnDB ()->getDB (); - ScopedLock dbLock (theApp->getTxnDB ()->getDBLock ()); - db->executeSQL (mTransaction->getSQLInsertReplaceHeader () + mTransaction->getSQL (getLedger (), status) + ";"); +{ // This can destroy metadata, so don't do it + return; } Transaction::pointer Transaction::transactionFromSQL (Database* db, bool bValidate)