Don't include unit test sources in code coverage (RIPD-1132):

Most files containing unit test code are moved to src/test. JTx and the test client code are not yet moved.
2025-12-06 17:27:52 +00:00 · 2016-09-02 15:25:05 -04:00
parent 8687f64429
commit 8f97889176
165 changed files with 2090 additions and 1693 deletions
--- a/src/test/app/Transaction_ordering_test.cpp
+++ b/src/test/app/Transaction_ordering_test.cpp
@@ -0,0 +1,144 @@
+//------------------------------------------------------------------------------
+/*
+    This file is part of rippled: https://github.com/ripple/rippled
+    Copyright (c) 2012, 2013 Ripple Labs Inc.
+    Permission to use, copy, modify, and/or distribute this software for any
+    purpose  with  or without fee is hereby granted, provided that the above
+    copyright notice and this permission notice appear in all copies.
+    THE  SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+    WITH  REGARD  TO  THIS  SOFTWARE  INCLUDING  ALL  IMPLIED  WARRANTIES  OF
+    MERCHANTABILITY  AND  FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+    ANY  SPECIAL ,  DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+    WHATSOEVER  RESULTING  FROM  LOSS  OF USE, DATA OR PROFITS, WHETHER IN AN
+    ACTION  OF  CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+    OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+*/
+//==============================================================================
+
+#include <BeastConfig.h>
+#include <ripple/core/JobQueue.h>
+#include <ripple/protocol/ErrorCodes.h>
+#include <ripple/test/jtx.h>
+
+namespace ripple {
+namespace test {
+
+struct Transaction_ordering_test : public beast::unit_test::suite
+{
+    void testCorrectOrder()
+    {
+        using namespace jtx;
+
+        Env env(*this);
+        auto const alice = Account("alice");
+        env.fund(XRP(1000), noripple(alice));
+
+        auto const aliceSequence = env.seq(alice);
+
+        auto const tx1 = env.jt(noop(alice), seq(aliceSequence));
+        auto const tx2 = env.jt(noop(alice), seq(aliceSequence + 1),
+            json(R"({"LastLedgerSequence":7})"));
+
+        env(tx1);
+        env.close();
+        BEAST_EXPECT(env.seq(alice) == aliceSequence + 1);
+        env(tx2);
+        env.close();
+        BEAST_EXPECT(env.seq(alice) == aliceSequence + 2);
+
+        env.close();
+
+        {
+            auto const result = env.rpc("tx", to_string(tx1.stx->getTransactionID()));
+            BEAST_EXPECT(result["result"]["meta"]["TransactionResult"] == "tesSUCCESS");
+        }
+        {
+            auto const result = env.rpc("tx", to_string(tx2.stx->getTransactionID()));
+            BEAST_EXPECT(result["result"]["meta"]["TransactionResult"] == "tesSUCCESS");
+        }
+    }
+
+    void testIncorrectOrder()
+    {
+        using namespace jtx;
+
+        Env env(*this);
+        env.app().getJobQueue().setThreadCount(0, false);
+        auto const alice = Account("alice");
+        env.fund(XRP(1000), noripple(alice));
+
+        auto const aliceSequence = env.seq(alice);
+
+        auto const tx1 = env.jt(noop(alice), seq(aliceSequence));
+        auto const tx2 = env.jt(noop(alice), seq(aliceSequence + 1),
+            json(R"({"LastLedgerSequence":7})"));
+
+        env(tx2, ter(terPRE_SEQ));
+        BEAST_EXPECT(env.seq(alice) == aliceSequence);
+        env(tx1);
+        env.app().getJobQueue().rendezvous();
+        BEAST_EXPECT(env.seq(alice) == aliceSequence + 2);
+
+        env.close();
+
+        {
+            auto const result = env.rpc("tx", to_string(tx1.stx->getTransactionID()));
+            BEAST_EXPECT(result["result"]["meta"]["TransactionResult"] == "tesSUCCESS");
+        }
+        {
+            auto const result = env.rpc("tx", to_string(tx2.stx->getTransactionID()));
+            BEAST_EXPECT(result["result"]["meta"]["TransactionResult"] == "tesSUCCESS");
+        }
+    }
+
+    void testIncorrectOrderMultipleIntermediaries()
+    {
+        using namespace jtx;
+
+        Env env(*this);
+        env.app().getJobQueue().setThreadCount(0, false);
+        auto const alice = Account("alice");
+        env.fund(XRP(1000), noripple(alice));
+
+        auto const aliceSequence = env.seq(alice);
+
+        std::vector<JTx> tx;
+        for (auto i = 0; i < 5; ++i)
+        {
+            tx.emplace_back(
+                env.jt(noop(alice), seq(aliceSequence + i),
+                    json(R"({"LastLedgerSequence":7})"))
+            );
+        }
+
+        for (auto i = 1; i < 5; ++i)
+        {
+            env(tx[i], ter(terPRE_SEQ));
+            BEAST_EXPECT(env.seq(alice) == aliceSequence);
+        }
+
+        env(tx[0]);
+        env.app().getJobQueue().rendezvous();
+        BEAST_EXPECT(env.seq(alice) == aliceSequence + 5);
+
+        env.close();
+
+        for (auto i = 0; i < 5; ++i)
+        {
+            auto const result = env.rpc("tx", to_string(tx[i].stx->getTransactionID()));
+            BEAST_EXPECT(result["result"]["meta"]["TransactionResult"] == "tesSUCCESS");
+        }
+    }
+
+    void run() override
+    {
+        testCorrectOrder();
+        testIncorrectOrder();
+        testIncorrectOrderMultipleIntermediaries();
+    }
+};
+
+BEAST_DEFINE_TESTSUITE(Transaction_ordering,app,ripple);
+
+} // test
+} // ripple