From 8aedbba785a4522d95d75f9bbe198e20a03861bc Mon Sep 17 00:00:00 2001
From: Richard Holland <richard.holland@starstone.co.nz>
Date: Fri, 14 Feb 2025 17:39:51 +1100
Subject: [PATCH] add more relaxed acid

---
 src/ripple/nodestore/backend/MySQLFactory.cpp | 29 ++++++++++++-------
 1 file changed, 18 insertions(+), 11 deletions(-)

diff --git a/src/ripple/nodestore/backend/MySQLFactory.cpp b/src/ripple/nodestore/backend/MySQLFactory.cpp
index ac2f4ff5d..66e111723 100644
--- a/src/ripple/nodestore/backend/MySQLFactory.cpp
+++ b/src/ripple/nodestore/backend/MySQLFactory.cpp
@@ -40,6 +40,10 @@ static constexpr auto INSERT_NODE = R"SQL(
     ON DUPLICATE KEY UPDATE data = VALUES(data)
 )SQL";
 
+static constexpr auto SET_ISOLATION_LEVEL = R"SQL(
+    SET SESSION TRANSACTION ISOLATION LEVEL READ UNCOMMITTED
+)SQL";
+
 class MySQLConnection
 {
 private:
@@ -76,6 +80,14 @@ private:
         if (!conn)
             return false;
 
+        // Set isolation level for dirty reads
+        if (mysql_query(mysql_.get(), SET_ISOLATION_LEVEL))
+        {
+            JLOG(journal_.warn()) << "Failed to set isolation level: "
+                                  << mysql_error(mysql_.get());
+            return false;
+        }
+
         // Create database (unconditionally)
         std::string query(1024, '\0');
         int length = snprintf(
@@ -532,12 +544,7 @@ public:
             return;
         }
 
-        if (mysql_stmt_execute(stmt))
-        {
-            mysql_stmt_close(stmt);
-            return;
-        }
-
+        mysql_stmt_execute(stmt);
         mysql_stmt_close(stmt);
     }
 
@@ -551,20 +558,20 @@ public:
         if (!conn->ensureConnection())
             return;
 
-        if (mysql_query(conn->get(), "START TRANSACTION"))
-            return;
+        //        if (mysql_query(conn->get(), "START TRANSACTION"))
+        //            return;
 
         try
         {
             for (auto const& e : batch)
                 store(e);
 
-            if (mysql_query(conn->get(), "COMMIT"))
-                mysql_query(conn->get(), "ROLLBACK");
+            //            if (mysql_query(conn->get(), "COMMIT"))
+            //                mysql_query(conn->get(), "ROLLBACK");
         }
         catch (...)
         {
-            mysql_query(conn->get(), "ROLLBACK");
+            //            mysql_query(conn->get(), "ROLLBACK");
             throw;
         }
     }