From 85a1eb5dbaaac4284e0651c77edc24f9d4a9a3c7 Mon Sep 17 00:00:00 2001 From: tequ Date: Tue, 1 Jul 2025 15:22:52 +0900 Subject: [PATCH] `Supported::No` for `featureMPTokensV1` --- include/xrpl/protocol/detail/features.macro | 2 +- src/test/app/Clawback_test.cpp | 2 +- src/test/app/MPToken_test.cpp | 10 +++++----- src/test/rpc/LedgerRPC_test.cpp | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/xrpl/protocol/detail/features.macro b/include/xrpl/protocol/detail/features.macro index cbb06ef4c..fd90292fb 100644 --- a/include/xrpl/protocol/detail/features.macro +++ b/include/xrpl/protocol/detail/features.macro @@ -34,7 +34,7 @@ XRPL_FEATURE(PermissionedDomains, Supported::yes, VoteBehavior::DefaultNo XRPL_FEATURE(DynamicNFT, Supported::yes, VoteBehavior::DefaultNo) XRPL_FEATURE(Credentials, Supported::yes, VoteBehavior::DefaultNo) XRPL_FEATURE(AMMClawback, Supported::yes, VoteBehavior::DefaultNo) -XRPL_FEATURE(MPTokensV1, Supported::yes, VoteBehavior::DefaultNo) +XRPL_FEATURE(MPTokensV1, Supported::no, VoteBehavior::DefaultNo) // InvariantsV1_1 will be changes to Supported::yes when all the // invariants expected to be included under it are complete. XRPL_FEATURE(InvariantsV1_1, Supported::no, VoteBehavior::DefaultNo) diff --git a/src/test/app/Clawback_test.cpp b/src/test/app/Clawback_test.cpp index c000433d2..c6623eaf7 100644 --- a/src/test/app/Clawback_test.cpp +++ b/src/test/app/Clawback_test.cpp @@ -953,7 +953,7 @@ public: run() override { using namespace test::jtx; - FeatureBitset const all{supported_amendments()}; + FeatureBitset const all{supported_amendments() | featureMPTokensV1}; testWithFeats(all - featureMPTokensV1); testWithFeats(all); diff --git a/src/test/app/MPToken_test.cpp b/src/test/app/MPToken_test.cpp index 690fcfdd0..54ec4d07c 100644 --- a/src/test/app/MPToken_test.cpp +++ b/src/test/app/MPToken_test.cpp @@ -1317,7 +1317,7 @@ class MPToken_test : public beast::unit_test::suite } void - testDepositPreauth() + testDepositPreauth(FeatureBitset features) { testcase("DepositPreauth"); @@ -1330,7 +1330,7 @@ class MPToken_test : public beast::unit_test::suite const char credType[] = "abcde"; { - Env env(*this); + Env env(*this, features); env.fund(XRP(50000), diana, dpIssuer); env.close(); @@ -1405,7 +1405,7 @@ class MPToken_test : public beast::unit_test::suite testcase("DepositPreauth disabled featureCredentials"); { - Env env(*this, supported_amendments() - featureCredentials); + Env env(*this, features - featureCredentials); std::string const credIdx = "D007AE4B6E1274B4AF872588267B810C2F82716726351D1C7D38D3E5499FC6" @@ -2308,7 +2308,7 @@ public: run() override { using namespace test::jtx; - FeatureBitset const all{supported_amendments()}; + FeatureBitset const all{supported_amendments() | featureMPTokensV1}; // MPTokenIssuanceCreate testCreateValidation(all); @@ -2332,7 +2332,7 @@ public: // Test Direct Payment testPayment(all); - testDepositPreauth(); + testDepositPreauth(all); // Test MPT Amount is invalid in Tx, which don't support MPT testMPTInvalidInTx(all); diff --git a/src/test/rpc/LedgerRPC_test.cpp b/src/test/rpc/LedgerRPC_test.cpp index 47829ba02..c85911167 100644 --- a/src/test/rpc/LedgerRPC_test.cpp +++ b/src/test/rpc/LedgerRPC_test.cpp @@ -3643,7 +3643,7 @@ public: testcase("ledger_entry Request MPT"); using namespace test::jtx; using namespace std::literals::chrono_literals; - Env env{*this}; + Env env{*this, supported_amendments() | featureMPTokensV1}; Account const alice{"alice"}; Account const bob("bob");