ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-12-06 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup code using move semantics

Browse Source
This commit is contained in:
seelabs
2020-04-10 14:07:31 -04:00
committed by manojsdoshi
parent 421417ab07
commit 6d28f2a8d9
25 changed files with 132 additions and 116 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/test/app/Manifest_test.cpp
View File

@@ -183,11 +183,13 @@ public:
Serializer s;
st.add(s);
std::string const m(static_cast<char const*>(s.data()), s.size());
// m is non-const so it can be moved from
std::string m(static_cast<char const*>(s.data()), s.size());
if (auto r = deserializeManifest(std::move(m)))
return std::move(*r);
Throw<std::runtime_error>("Could not create a revocation manifest");
return *deserializeManifest(std::move(m)); // Silence compiler warning.
return *deserializeManifest(
std::string{}); // Silence compiler warning.
}
Manifest
@@ -223,11 +225,14 @@ public:
Serializer s;
st.add(s);
std::string const m(static_cast<char const*>(s.data()), s.size());
std::string m(
static_cast<char const*>(s.data()),
s.size()); // non-const so can be moved
if (auto r = deserializeManifest(std::move(m)))
return std::move(*r);
Throw<std::runtime_error>("Could not create a manifest");
return *deserializeManifest(std::move(m)); // Silence compiler warning.
return *deserializeManifest(
std::string{}); // Silence compiler warning.
}
Manifest