From 6a0c26a709077aae78b4474b190fe5e469890161 Mon Sep 17 00:00:00 2001 From: seelabs Date: Tue, 21 Apr 2015 09:42:05 -0700 Subject: [PATCH] Fix return value when looking up non existent transactions --- src/ripple/app/tx/Transaction.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/ripple/app/tx/Transaction.cpp b/src/ripple/app/tx/Transaction.cpp index 723bed1f8..8b7984240 100644 --- a/src/ripple/app/tx/Transaction.cpp +++ b/src/ripple/app/tx/Transaction.cpp @@ -161,8 +161,10 @@ Transaction::pointer Transaction::load (uint256 const& id) *db << sql, soci::into (ledgerSeq), soci::into (status), soci::into (sociRawTxnBlob, rti); - if (db->got_data () && soci::i_ok == rti) - convert(sociRawTxnBlob, rawTxn); + if (!db->got_data () || rti != soci::i_ok) + return {}; + + convert(sociRawTxnBlob, rawTxn); } return Transaction::transactionFromSQL (