ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-12-06 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't call getCurrentSnapshot without the master lock

Browse Source
This commit is contained in:
JoelKatz
2013-07-12 11:25:48 -07:00
parent ae50bf34aa
commit 62bd05a99a
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/cpp/ripple/RPCHandler.cpp
View File

@@ -107,9 +107,10 @@ Json::Value RPCHandler::transactionSign (Json::Value params, bool bSubmit, bool
return rpcError (rpcINVALID_PARAMS);
}
Ledger::pointer lSnapshot = mNetOps->getCurrentSnapshot ();
AccountState::pointer asSrc = bOffline
? AccountState::pointer () // Don't look up address if offline.
: mNetOps->getAccountState (mNetOps->getCurrentSnapshot (), raSrcAddressID);
: mNetOps->getAccountState (lSnapshot, raSrcAddressID);
mlh.unlock();
if (!bOffline && !asSrc)
@@ -179,7 +180,6 @@ Json::Value RPCHandler::transactionSign (Json::Value params, bool bSubmit, bool
return rpcError (rpcINVALID_PARAMS);
}
Ledger::pointer lSnapshot = mNetOps->getCurrentSnapshot ();
{
bool bValid;
RippleLineCache::pointer cache = boost::make_shared<RippleLineCache> (lSnapshot);
@@ -232,8 +232,7 @@ Json::Value RPCHandler::transactionSign (Json::Value params, bool bSubmit, bool
if (!bOffline)
{
Ledger::pointer lpCurrent = mNetOps->getCurrentSnapshot ();
SLE::pointer sleAccountRoot = mNetOps->getSLEi (lpCurrent, Ledger::getAccountRootIndex (raSrcAddressID.getAccountID ()));
SLE::pointer sleAccountRoot = mNetOps->getSLEi (lSnapshot, Ledger::getAccountRootIndex (raSrcAddressID.getAccountID ()));
if (!sleAccountRoot)
{