From 60c59a5bb295fec165bc71da9a45aa03d061903e Mon Sep 17 00:00:00 2001 From: Nicholas Dudfield Date: Thu, 24 Sep 2026 05:50:37 +0700 Subject: [PATCH] Revert "fix(test): expect config-forced amendments only where the Env forces them" This reverts commit 067ad43b3639ecba082e3de1565a0a148015a864. --- src/test/rpc/ServerDefinitions_test.cpp | 14 +------------- src/xrpld/rpc/handlers/ServerDefinitions.cpp | 2 +- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/test/rpc/ServerDefinitions_test.cpp b/src/test/rpc/ServerDefinitions_test.cpp index 401080d2fc..d73ba5e976 100644 --- a/src/test/rpc/ServerDefinitions_test.cpp +++ b/src/test/rpc/ServerDefinitions_test.cpp @@ -24,8 +24,6 @@ #include #include -#include - namespace ripple { namespace test { @@ -184,14 +182,6 @@ public: std::map const& votes = ripple::detail::supportedAmendments(); - // The jtx fixture does not force every supported amendment through - // config (this lineage keeps ConsensusEntropy out of the default set), - // so "enabled" is expected exactly for what the Env's config forces. - std::set forced; - for (auto const& h : env.app().config().features) - if (auto const fname = featureToName(h); !fname.empty()) - forced.insert(fname); - auto jrr = env.rpc("server_definitions")[jss::result]; if (!BEAST_EXPECT(jrr.isMember(jss::features))) return; @@ -205,11 +195,9 @@ public: bool expectObsolete = (votes.at(feature[jss::name].asString()) == VoteBehavior::Obsolete); - bool const expectForced = - forced.count(feature[jss::name].asString()) != 0; BEAST_EXPECTS( feature.isMember(jss::enabled) && - feature[jss::enabled].asBool() == expectForced, + feature[jss::enabled].asBool(), feature[jss::name].asString() + " enabled"); BEAST_EXPECTS( feature.isMember(jss::ledger_enabled) && diff --git a/src/xrpld/rpc/handlers/ServerDefinitions.cpp b/src/xrpld/rpc/handlers/ServerDefinitions.cpp index 643105b8be..df3f02b4dc 100644 --- a/src/xrpld/rpc/handlers/ServerDefinitions.cpp +++ b/src/xrpld/rpc/handlers/ServerDefinitions.cpp @@ -23,8 +23,8 @@ #include #include #include -#include #include +#include #include #include #include