ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-12-06 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add negative caching for HashedObject class. This massively reduces

Browse Source 
contention for the database lock under high network ledger fetch load.
This commit is contained in:
JoelKatz
2013-01-08 14:50:03 -08:00
parent fbac342e2e
commit 607e2039e2
3 changed files with 125 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/cpp/ripple/HashedObject.cpp
View File

@@ -33,6 +33,7 @@ bool HashedObjectStore::store(HashedObjectType type, uint32 index,
}
assert(hash == Serializer::getSHA512Half(data));
mNegativeCache.del(hash);
HashedObject::pointer object = boost::make_shared<HashedObject>(type, index, data, hash);
if (!mCache.canonicalize(hash, object))
{
@@ -115,6 +116,7 @@ void HashedObjectStore::bulkWrite()
HashedObject::pointer HashedObjectStore::retrieve(const uint256& hash)
{
HashedObject::pointer obj;
{
obj = mCache.fetch(hash);
@@ -125,6 +127,9 @@ HashedObject::pointer HashedObjectStore::retrieve(const uint256& hash)
}
}
if (mNegativeCache.isPresent(hash))
return HashedObject::pointer();
if (!theApp || !theApp->getHashNodeDB())
return HashedObject::pointer();
std::string sql = "SELECT * FROM CommittedObjects WHERE Hash='";
@@ -139,12 +144,17 @@ HashedObject::pointer HashedObjectStore::retrieve(const uint256& hash)
if (!db->executeSQL(sql) || !db->startIterRows())
{
// cLog(lsTRACE) << "HOS: " << hash << " fetch: not in db";
mNegativeCache.add(hash);
return HashedObject::pointer();
}
std::string type;
db->getStr("ObjType", type);
if (type.size() == 0) return HashedObject::pointer();
if (type.size() == 0)
{
mNegativeCache.add(hash);
return HashedObject::pointer();
}
uint32 index = db->getBigInt("LedgerIndex");
@@ -164,6 +174,7 @@ HashedObject::pointer HashedObjectStore::retrieve(const uint256& hash)
case 'N': htype = hotTRANSACTION_NODE; break;
default:
cLog(lsERROR) << "Invalid hashed object";
mNegativeCache.add(hash);
return HashedObject::pointer();
}