ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-11-20 18:45:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Introduce the NonFungibleTokensV1_1 amendment:

Browse Source 
The XLS-20 implementation contained two bugs that would require the
introduction of amendments. This complicates the adoption of XLS-20
by requiring a staggered amendment activation, first of the two fix
amendments, followed by the `NonFungibleTokensV1` amendment.

After consideration, the consensus among node operators is that the
process should be simplified by the introduction of a new amendment
that, if enabled, would behaves as if the `NonFungibleTokensV1` and
the two fix amendments (`fixNFTokenDirV1` and `fixNFTokenNegOffer`)
were activated at once.

This commit implements this proposal; it does not introduce any new
functionality or additional features, above and beyond that offered
by the existing amendments.
This commit is contained in:
Nik Bougalis
2022-07-06 12:49:00 -07:00
parent 9eb303f8e8
commit 59326bbbc5
5 changed files with 30 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/test/app/NFToken_test.cpp
View File

@@ -96,7 +96,10 @@ class NFToken_test : public beast::unit_test::suite
{
// If the NFT amendment is not enabled, you should not be able
// to create or burn NFTs.
Env env{*this, features - featureNonFungibleTokensV1};
Env env{
*this,
features - featureNonFungibleTokensV1 -
featureNonFungibleTokensV1_1};
Account const& master = env.master;
BEAST_EXPECT(ownerCount(env, master) == 0);
@@ -4650,7 +4653,8 @@ class NFToken_test : public beast::unit_test::suite
// Test both with and without fixNFTokenNegOffer
for (auto const& tweakedFeatures :
{features - fixNFTokenNegOffer, features | fixNFTokenNegOffer})
{features - fixNFTokenNegOffer - featureNonFungibleTokensV1_1,
features | fixNFTokenNegOffer})
{
// There was a bug in the initial NFT implementation that
// allowed offers to be placed with negative amounts. Verify
@@ -4759,7 +4763,9 @@ class NFToken_test : public beast::unit_test::suite
// Test what happens if NFTokenOffers are created with negative amounts
// and then fixNFTokenNegOffer goes live. What does an acceptOffer do?
{
Env env{*this, features - fixNFTokenNegOffer};
Env env{
*this,
features - fixNFTokenNegOffer - featureNonFungibleTokensV1_1};
env.fund(XRP(1000000), issuer, buyer, gw);
env.close();
@@ -4844,7 +4850,8 @@ class NFToken_test : public beast::unit_test::suite
// Test buy offers with a destination with and without
// fixNFTokenNegOffer.
for (auto const& tweakedFeatures :
{features - fixNFTokenNegOffer, features | fixNFTokenNegOffer})
{features - fixNFTokenNegOffer - featureNonFungibleTokensV1_1,
features | fixNFTokenNegOffer})
{
Env env{*this, tweakedFeatures};