diff --git a/src/xrpld/app/misc/detail/AmendmentTable.cpp b/src/xrpld/app/misc/detail/AmendmentTable.cpp index d496fc4e5..d7a5ae824 100644 --- a/src/xrpld/app/misc/detail/AmendmentTable.cpp +++ b/src/xrpld/app/misc/detail/AmendmentTable.cpp @@ -226,7 +226,10 @@ public: toBase58(TokenType::NodePublic, votes.first); if (!votes.second.timeout) { - assert(votes.second.upVotes.empty()); + XRPL_ASSERT( + votes.second.upVotes.empty(), + "ripple::TrustedVotes::recordVotes : received no " + "upvotes"); JLOG(j.debug()) << "recordVotes: Have not received any " "amendment votes from " @@ -242,7 +245,10 @@ public: } else if (votes.second.timeout != newTimeout) { - assert(votes.second.timeout < newTimeout); + XRPL_ASSERT( + votes.second.timeout < newTimeout, + "ripple::TrustedVotes::recordVotes : votes not " + "expired"); using namespace std::chrono; auto const age = duration_cast( newTimeout - *votes.second.timeout); @@ -262,9 +268,10 @@ public: int available = 0; for (auto& validatorVotes : recordedVotes_) { - assert( + XRPL_ASSERT( validatorVotes.second.timeout || - validatorVotes.second.upVotes.empty()); + validatorVotes.second.upVotes.empty(), + "ripple::TrustedVotes::getVotes : valid votes"); if (validatorVotes.second.timeout) ++available; for (uint256 const& amendment : validatorVotes.second.upVotes) diff --git a/src/xrpld/overlay/detail/PeerImp.cpp b/src/xrpld/overlay/detail/PeerImp.cpp index 73ed6eee3..700966b6d 100644 --- a/src/xrpld/overlay/detail/PeerImp.cpp +++ b/src/xrpld/overlay/detail/PeerImp.cpp @@ -1246,7 +1246,7 @@ PeerImp::handleTransaction( { XRPL_ASSERT( eraseTxQueue != batch, - "ripple::PeerImp::handleTransaction correct function params"); + ("ripple::PeerImp::handleTransaction : valid inputs")); if (tracking_.load() == Tracking::diverged) return; diff --git a/src/xrpld/overlay/detail/PeerImp.h b/src/xrpld/overlay/detail/PeerImp.h index 9f52c1c7a..23916db21 100644 --- a/src/xrpld/overlay/detail/PeerImp.h +++ b/src/xrpld/overlay/detail/PeerImp.h @@ -153,7 +153,9 @@ private: void update(Resource::Charge f, std::string const& add) { - assert(f >= fee); + XRPL_ASSERT( + f >= fee, + "ripple::PeerImp::ChargeWithContext::update : fee increases"); fee = f; if (!context.empty()) {