ARCHIVE/xahaud
3
0
Fork 0
mirror of https://github.com/Xahau/xahaud.git synced 2025-12-06 17:27:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reject invalid MessageKey in SetAccount handler (RIPD-308, RIPD-990)

Browse Source
This commit is contained in:
Nik Bougalis
2016-05-01 17:29:04 -07:00
committed by Howard Hinnant
parent 2ae68923cc
commit 4d19b8be07
2 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/ripple/app/tx/impl/SetAccount.cpp
View File

@@ -23,6 +23,7 @@
#include <ripple/core/Config.h> #include <ripple/core/Config.h>
#include <ripple/protocol/Feature.h> #include <ripple/protocol/Feature.h>
#include <ripple/protocol/Indexes.h> #include <ripple/protocol/Indexes.h>
#include <ripple/protocol/PublicKey.h>
#include <ripple/protocol/Quality.h> #include <ripple/protocol/Quality.h>
#include <ripple/protocol/st.h> #include <ripple/protocol/st.h>
#include <ripple/ledger/View.h> #include <ripple/ledger/View.h>
@@ -123,15 +124,17 @@ SetAccount::preflight (PreflightContext const& ctx)
} }
} }
auto const messageKey = tx[~sfMessageKey]; if (auto const mk = tx[~sfMessageKey])
if (messageKey && messageKey->size() > PUBLIC_BYTES_MAX)
{ {
JLOG(j.trace()) << "message key too long"; if (mk->size() && ! publicKeyType ({mk->data(), mk->size()}))
{
JLOG(j.trace()) << "Invalid message key specified.";
return telBAD_PUBLIC_KEY; return telBAD_PUBLIC_KEY;
} }
}
auto const domain = tx[~sfDomain]; auto const domain = tx[~sfDomain];
if (domain&& domain->size() > DOMAIN_BYTES_MAX) if (domain && domain->size() > DOMAIN_BYTES_MAX)
{ {
JLOG(j.trace()) << "domain too long"; JLOG(j.trace()) << "domain too long";
return telBAD_DOMAIN; return telBAD_DOMAIN;

1
src/ripple/app/tx/impl/SetAccount.h
View File

@@ -33,7 +33,6 @@ class SetAccount
: public Transactor : public Transactor
{ {
static std::size_t const DOMAIN_BYTES_MAX = 256; static std::size_t const DOMAIN_BYTES_MAX = 256;
static std::size_t const PUBLIC_BYTES_MAX = 33;
public: public:
SetAccount (ApplyContext& ctx) SetAccount (ApplyContext& ctx)