Suppress warnings & allow copy elision:

* Suppress warnings from rocksdb2
* Add `override` to rippled rocksdb functions
* Remove moves preventing copy elision
This commit is contained in:
seelabs
2015-09-26 13:15:16 -04:00
committed by Vinnie Falco
parent 9315d98aa9
commit 442ad4e445
7 changed files with 62 additions and 28 deletions

View File

@@ -792,7 +792,7 @@ Json::Value transactionSignFor (
{
Json::Value err = checkMultiSignFields (jvRequest);
if (RPC::contains_error (err))
return std::move (err);
return err;
}
// Add and amend fields based on the transaction type.
@@ -880,7 +880,7 @@ Json::Value transactionSubmitMultiSigned (
{
Json::Value err = checkMultiSignFields (jvRequest);
if (RPC::contains_error (err))
return std::move (err);
return err;
}
Json::Value& tx_json (jvRequest ["tx_json"]);
@@ -913,7 +913,7 @@ Json::Value transactionSubmitMultiSigned (
jvRequest, role, false, app.config(), app.getFeeTrack(), ledger);
if (RPC::contains_error(err))
return std::move (err);
return err;
err = checkPayment (
jvRequest,
@@ -925,7 +925,7 @@ Json::Value transactionSubmitMultiSigned (
false);
if (RPC::contains_error(err))
return std::move (err);
return err;
}
// Grind through the JSON in tx_json to produce a STTx