From 4221dcf5681d96488fa23c5c76e352e53a74c621 Mon Sep 17 00:00:00 2001
From: tequ <git@tequ.dev>
Date: Fri, 18 Apr 2025 08:34:44 +0900
Subject: [PATCH] Add tests for SetRemarks (#491)

---
 src/ripple/app/tx/impl/SetRemarks.cpp | 10 +++++-----
 src/test/app/SetRemarks_test.cpp      |  6 ++----
 2 files changed, 7 insertions(+), 9 deletions(-)

diff --git a/src/ripple/app/tx/impl/SetRemarks.cpp b/src/ripple/app/tx/impl/SetRemarks.cpp
index f45479bf5..0edc67121 100644
--- a/src/ripple/app/tx/impl/SetRemarks.cpp
+++ b/src/ripple/app/tx/impl/SetRemarks.cpp
@@ -25,6 +25,7 @@
 #include <ripple/protocol/Indexes.h>
 #include <ripple/protocol/PublicKey.h>
 #include <ripple/protocol/Quality.h>
+#include <ripple/protocol/TxFlags.h>
 #include <ripple/protocol/st.h>
 
 namespace ripple {
@@ -313,22 +314,21 @@ SetRemarks::preclaim(PreclaimContext const& ctx)
 TER
 SetRemarks::doApply()
 {
-    auto j = ctx_.journal;
     Sandbox sb(&ctx_.view());
 
     auto const sle = sb.read(keylet::account(account_));
     if (!sle)
-        return terNO_ACCOUNT;
+        return tefINTERNAL;
 
     auto const objID = ctx_.tx[sfObjectID];
     auto sleO = sb.peek(keylet::unchecked(objID));
     if (!sleO)
-        return terNO_ACCOUNT;
+        return tefINTERNAL;
 
     std::optional<AccountID> issuer = getRemarksIssuer(sleO);
 
     if (!issuer || *issuer != account_)
-        return tecNO_PERMISSION;
+        return tefINTERNAL;
 
     auto const& remarksTxn = ctx_.tx.getFieldArray(sfRemarks);
 
@@ -400,7 +400,7 @@ SetRemarks::doApply()
     }
 
     if (newRemarks.size() > 32)
-        return tecTOO_MANY_REMARKS;
+        return tefINTERNAL;
 
     if (newRemarks.empty() && sleO->isFieldPresent(sfRemarks))
         sleO->makeFieldAbsent(sfRemarks);
diff --git a/src/test/app/SetRemarks_test.cpp b/src/test/app/SetRemarks_test.cpp
index 8948c4613..82b782035 100644
--- a/src/test/app/SetRemarks_test.cpp
+++ b/src/test/app/SetRemarks_test.cpp
@@ -377,10 +377,8 @@ struct SetRemarks_test : public beast::unit_test::suite
         //----------------------------------------------------------------------
         // doApply
 
-        // terNO_ACCOUNT
-        // tecNO_TARGET
-        // tecNO_PERMISSION
-        // tecTOO_MANY_REMARKS
+        // All checks in doApply are done in preclaim.
+        BEAST_EXPECT(1);
     }
 
     void