mirror of
https://github.com/Xahau/xahaud.git
synced 2025-12-06 17:27:52 +00:00
Minimize use of jtx::with_only_features (RIPD-1515):
In order to automatically run unit tests with newly created amendments, prefer to start with jtx::supported_features() and then subtract unwanted features. These changes identified a few bugs that were hiding in amendments. One of those bugs, in FlowCross, is not yet fixed. By uncommenting the test in CrossingLimits_test.cpp you can see failures relating to that bug. Since FlowCross is not yet enabled on the network we can fix the bug at our convenience.
This commit is contained in:
@@ -25,10 +25,10 @@ namespace test {
|
||||
|
||||
struct BookDirs_test : public beast::unit_test::suite
|
||||
{
|
||||
void test_bookdir(std::initializer_list<uint256> fs)
|
||||
void test_bookdir(FeatureBitset features)
|
||||
{
|
||||
using namespace jtx;
|
||||
Env env(*this, with_only_features(fs));
|
||||
Env env(*this, features);
|
||||
auto gw = Account("gw");
|
||||
auto USD = gw["USD"];
|
||||
env.fund(XRP(1000000), "alice", "bob", "gw");
|
||||
@@ -94,9 +94,12 @@ struct BookDirs_test : public beast::unit_test::suite
|
||||
|
||||
void run() override
|
||||
{
|
||||
test_bookdir({});
|
||||
test_bookdir({featureFlow, fix1373});
|
||||
test_bookdir({featureFlow, fix1373, featureFlowCross});
|
||||
using namespace jtx;
|
||||
test_bookdir(
|
||||
supported_features_except (featureFlow, fix1373, featureFlowCross));
|
||||
test_bookdir(
|
||||
supported_features_except ( featureFlowCross));
|
||||
test_bookdir(supported_amendments ());
|
||||
}
|
||||
};
|
||||
|
||||
|
||||
Reference in New Issue
Block a user