XLS-46: DynamicNFT (#5048)

This Amendment adds functionality to update the URI of NFToken objects as described in the XLS-46d: Dynamic Non Fungible Tokens (dNFTs) spec.

include/xrpl/protocol/Feature.h

@@ -80,7 +80,7 @@ namespace detail {
 // Feature.cpp. Because it's only used to reserve storage, and determine how
 // large to make the FeatureBitset, it MAY be larger. It MUST NOT be less than
 // the actual number of amendments. A LogicError on startup will verify this.
-static constexpr std::size_t numFeatures = 106;
+static constexpr std::size_t numFeatures = 107;
 
 /** Amendments that this server supports and the default voting behavior.
    Whether they are enabled depends on the Rules defined in the validated

include/xrpl/protocol/TxFlags.h

@@ -149,12 +149,10 @@ enum NFTokenMintFlags : uint32_t {
     tfOnlyXRP = 0x00000002,
     tfTrustLine = 0x00000004,
     tfTransferable = 0x00000008,
+    tfMutable = 0x00000010,
     tfStrongTSH = 0x00008000,
 };
 
-constexpr std::uint32_t const tfNFTokenMintOldMask =
-    ~(tfUniversal | tfBurnable | tfOnlyXRP | tfTrustLine | tfTransferable | tfStrongTSH);
-
 // MPTokenIssuanceCreate flags:
 // NOTE - there is intentionally no flag here for lsfMPTLocked, which this transaction cannot mutate. 
 enum MPTokenIssuanceCreateFlags : uint32_t {
@@ -197,10 +195,19 @@ constexpr std::uint32_t const tfMPTokenIssuanceDestroyMask  = ~tfUniversal;
 // The fixRemoveNFTokenAutoTrustLine amendment disables minting with the
 // tfTrustLine flag as a way to prevent the attack.  But until the
 // amendment passes we still need to keep the old behavior available.
-
 constexpr std::uint32_t const tfNFTokenMintMask =
     ~(tfUniversal | tfBurnable | tfOnlyXRP | tfTransferable | tfStrongTSH);
 
+constexpr std::uint32_t const tfNFTokenMintOldMask =
+    ~( ~tfNFTokenMintMask | tfTrustLine);
+
+// if featureDynamicNFT enabled then new flag allowing mutable URI available.
+constexpr std::uint32_t const tfNFTokenMintOldMaskWithMutable =
+    ~( ~tfNFTokenMintOldMask | tfMutable);
+
+constexpr std::uint32_t const tfNFTokenMintMaskWithMutable =
+    ~( ~tfNFTokenMintMask | tfMutable);
+
 // NFTokenCreateOffer flags:
 enum NFTokenCreateOfferFlags : uint32_t {
     tfSellNFToken = 0x00000001,
@@ -228,17 +235,17 @@ constexpr std::uint32_t const tfClaimRewardMask = ~(tfUniversal | tfOptOut);
 constexpr std::uint32_t const tfImmutable = 1;
 
 // Clawback flags:
-constexpr std::uint32_t const tfClawbackMask     = ~tfUniversal;
+constexpr std::uint32_t const tfClawbackMask               = ~tfUniversal;
 
 // AMM Flags:
-constexpr std::uint32_t tfLPToken                      = 0x00010000;
-constexpr std::uint32_t tfWithdrawAll                  = 0x00020000;
-constexpr std::uint32_t tfOneAssetWithdrawAll          = 0x00040000;
-constexpr std::uint32_t tfSingleAsset                  = 0x00080000;
-constexpr std::uint32_t tfTwoAsset                     = 0x00100000;
-constexpr std::uint32_t tfOneAssetLPToken              = 0x00200000;
-constexpr std::uint32_t tfLimitLPToken                 = 0x00400000;
-constexpr std::uint32_t tfTwoAssetIfEmpty              = 0x00800000;
+constexpr std::uint32_t tfLPToken                          = 0x00010000;
+constexpr std::uint32_t tfWithdrawAll                      = 0x00020000;
+constexpr std::uint32_t tfOneAssetWithdrawAll              = 0x00040000;
+constexpr std::uint32_t tfSingleAsset                      = 0x00080000;
+constexpr std::uint32_t tfTwoAsset                         = 0x00100000;
+constexpr std::uint32_t tfOneAssetLPToken                  = 0x00200000;
+constexpr std::uint32_t tfLimitLPToken                     = 0x00400000;
+constexpr std::uint32_t tfTwoAssetIfEmpty                  = 0x00800000;
 constexpr std::uint32_t tfWithdrawSubTx =
     tfLPToken | tfSingleAsset | tfTwoAsset | tfOneAssetLPToken |
     tfLimitLPToken | tfWithdrawAll | tfOneAssetWithdrawAll;

include/xrpl/protocol/detail/features.macro

@@ -29,6 +29,7 @@
 // If you add an amendment here, then do not forget to increment `numFeatures`
 // in include/xrpl/protocol/Feature.h.
 
+XRPL_FEATURE(DynamicNFT,                 Supported::yes, VoteBehavior::DefaultNo)
 XRPL_FEATURE(Credentials,                Supported::yes, VoteBehavior::DefaultNo)
 XRPL_FEATURE(AMMClawback,                Supported::yes, VoteBehavior::DefaultNo)
 XRPL_FIX    (AMMv1_2,                    Supported::yes, VoteBehavior::DefaultNo)

include/xrpl/protocol/detail/transactions.macro

@@ -481,6 +481,13 @@ TRANSACTION(ttCREDENTIAL_DELETE, 69, CredentialDelete, ({
     {sfCredentialType, soeREQUIRED},
 }))
 
+/** This transaction type modify a NFToken */
+TRANSACTION(ttNFTOKEN_MODIFY, 70, NFTokenModify, ({
+    {sfNFTokenID, soeREQUIRED},
+    {sfOwner, soeOPTIONAL},
+    {sfURI, soeOPTIONAL},
+}))
+
 /* A note attaching transactor that allows the owner or issuer (on a object by object basis) to attach remarks */
 TRANSACTION(ttREMARKS_SET, 94, SetRemarks, ({
     {sfObjectID, soeREQUIRED},
@@ -538,7 +545,6 @@ TRANSACTION(ttAMENDMENT, 100, EnableAmendment, ({
 }))
 
 /** This system-generated transaction type is used to update the network's fee settings.
-
     For details, see: https://xrpl.org/fee-voting.html
  */
 TRANSACTION(ttFEE, 101, SetFee, ({

include/xrpl/protocol/nft.h

@@ -54,6 +54,7 @@ constexpr std::uint16_t const flagBurnable = 0x0001;
 constexpr std::uint16_t const flagOnlyXRP = 0x0002;
 constexpr std::uint16_t const flagCreateTrustLines = 0x0004;
 constexpr std::uint16_t const flagTransferable = 0x0008;
+constexpr std::uint16_t const flagMutable = 0x0010;
 
 inline std::uint16_t
 getFlags(uint256 const& id)