From 23ce4318768b718c82e01004d23f1abc9a9549ff Mon Sep 17 00:00:00 2001 From: Alexander Kremer Date: Fri, 9 Sep 2022 20:49:42 +0100 Subject: [PATCH] Remove const_cast usage --- src/ripple/rpc/BookChanges.h | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/ripple/rpc/BookChanges.h b/src/ripple/rpc/BookChanges.h index 5aef1c693..7d7978d3f 100644 --- a/src/ripple/rpc/BookChanges.h +++ b/src/ripple/rpc/BookChanges.h @@ -88,13 +88,10 @@ computeBookChanges(std::shared_ptr const& lpAccepted) !node.isFieldPresent(sfPreviousFields)) continue; - STObject& finalFields = (const_cast(node)) - .getField(sfFinalFields) - .downcast(); - - STObject& previousFields = (const_cast(node)) - .getField(sfPreviousFields) - .downcast(); + auto const& ffBase = node.peekAtField(sfFinalFields); + auto const& finalFields = ffBase.template downcast(); + auto const& pfBase = node.peekAtField(sfPreviousFields); + auto const& previousFields = pfBase.template downcast(); // defensive case that should never be hit if (!finalFields.isFieldPresent(sfTakerGets) ||