From 1f5d380546f121289a3f2ea8652ab2213a472d49 Mon Sep 17 00:00:00 2001 From: JoelKatz Date: Sat, 13 Apr 2013 19:11:55 -0700 Subject: [PATCH] Mark some code that doesn't do what it might appear to. --- src/cpp/ripple/RippleCalc.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/cpp/ripple/RippleCalc.cpp b/src/cpp/ripple/RippleCalc.cpp index e92527cf8..bfe16e564 100644 --- a/src/cpp/ripple/RippleCalc.cpp +++ b/src/cpp/ripple/RippleCalc.cpp @@ -884,9 +884,13 @@ TER RippleCalc::calcNodeAdvance( } if (bDirectAdvance) - { - // Get next quality. + { // Get next quality. + + // FIXME: This looks at the original ledger and doesn't take into account any changes + // in the LedgerEntrySet. If this code, for example, created offers, this would + // not return the pages they're in. uDirectTip = lesActive.getLedger()->getNextLedgerIndex(uDirectTip, uDirectEnd); + bDirectDirDirty = true; bDirectAdvance = false;