From 0d1d6498674de7c790b349394c72b1f4e84a730a Mon Sep 17 00:00:00 2001
From: Nicholas Dudfield <ndudfield@gmail.com>
Date: Mon, 22 Jun 2026 15:33:29 +0700
Subject: [PATCH] refactor(consensus): remove orphaned txset cache callback

---
 src/test/consensus/ConsensusExtensions_test.cpp | 2 --
 src/xrpld/consensus/Consensus.h                 | 5 -----
 src/xrpld/consensus/ConsensusTypes.h            | 1 -
 3 files changed, 8 deletions(-)

diff --git a/src/test/consensus/ConsensusExtensions_test.cpp b/src/test/consensus/ConsensusExtensions_test.cpp
index c09d8792d..f2bb01dd0 100644
--- a/src/test/consensus/ConsensusExtensions_test.cpp
+++ b/src/test/consensus/ConsensusExtensions_test.cpp
@@ -570,7 +570,6 @@ struct ExportTickHarness
     std::size_t prevProposers = 4;
     int updates = 0;
     int proposes = 0;
-    int caches = 0;
 
     void
     addPeer(
@@ -633,7 +632,6 @@ struct ExportTickHarness
                 },
             .propose = [&]() { ++proposes; },
             .haveConsensus = []() { return true; },
-            .cacheAndShareTxSet = [&](FakeTxSet const&) { ++caches; },
             .getTxns = [&]() -> FakeTxSet const& { return txns; }};
 
         return extensionsTick(ext, ctx);
diff --git a/src/xrpld/consensus/Consensus.h b/src/xrpld/consensus/Consensus.h
index 634b3dade..f77e71987 100644
--- a/src/xrpld/consensus/Consensus.h
+++ b/src/xrpld/consensus/Consensus.h
@@ -1603,11 +1603,6 @@ Consensus<Adaptor>::phaseEstablish(
                     },
                 .propose = [&]() { adaptor_.propose(result_->position); },
                 .haveConsensus = [&]() { return haveConsensus(clog); },
-                .cacheAndShareTxSet =
-                    [&](TxSet_t const& txSet) {
-                        acquired_.emplace(txSet.id(), txSet);
-                        adaptor_.share(txSet);
-                    },
                 .getTxns = [&]() -> TxSet_t const& { return result_->txns; },
             };
         auto tickResult = adaptor_.ce().onTick(ctx);
diff --git a/src/xrpld/consensus/ConsensusTypes.h b/src/xrpld/consensus/ConsensusTypes.h
index b3f4a69ac..18a750249 100644
--- a/src/xrpld/consensus/ConsensusTypes.h
+++ b/src/xrpld/consensus/ConsensusTypes.h
@@ -331,7 +331,6 @@ struct ConsensusTick
     std::function<void(Position const&)> updatePosition;
     std::function<void()> propose;
     std::function<bool()> haveConsensus;
-    std::function<void(TxSet const&)> cacheAndShareTxSet;
     std::function<TxSet const&()> getTxns;
 };