From 040982e3210c9f459c7a684635acdb7acdde02cc Mon Sep 17 00:00:00 2001 From: Nik Bougalis Date: Mon, 9 Mar 2015 22:26:51 -0700 Subject: [PATCH] Only report 'delivered_amount' for executed payments (RIPD-827) --- src/ripple/rpc/impl/Utilities.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/ripple/rpc/impl/Utilities.cpp b/src/ripple/rpc/impl/Utilities.cpp index ca4c7b847..20fc727c2 100644 --- a/src/ripple/rpc/impl/Utilities.cpp +++ b/src/ripple/rpc/impl/Utilities.cpp @@ -32,7 +32,9 @@ addPaymentDeliveredAmount ( { STTx::pointer serializedTx; - if (transaction) + // We only want to add a "delivered_amount" field if the transaction + // succeeded - otherwise nothing could have been delivered. + if (transaction && transaction->getResult () == tesSUCCESS) serializedTx = transaction->getSTransaction (); if (serializedTx && serializedTx->getTxnType () == ttPAYMENT)