Remove an unused argument from ripple::verify

This commit is contained in:
Nik Bougalis
2016-10-07 10:36:26 -07:00
committed by Edward Hennis
parent b55edfa8f0
commit 027b289c91
4 changed files with 6 additions and 7 deletions

View File

@@ -100,11 +100,11 @@ bool Manifest::verify () const
STObject st (sfGeneric); STObject st (sfGeneric);
SerialIter sit (serialized.data (), serialized.size ()); SerialIter sit (serialized.data (), serialized.size ());
st.set (sit); st.set (sit);
if (! ripple::verify (st, HashPrefix::manifest, signingKey, true)) if (! ripple::verify (st, HashPrefix::manifest, signingKey))
return false; return false;
return ripple::verify ( return ripple::verify (
st, HashPrefix::manifest, masterKey, true, sfMasterSignature); st, HashPrefix::manifest, masterKey, sfMasterSignature);
} }
uint256 Manifest::hash () const uint256 Manifest::hash () const

View File

@@ -54,7 +54,7 @@ sign (STObject& st, HashPrefix const& prefix,
*/ */
bool bool
verify (STObject const& st, HashPrefix const& prefix, verify (STObject const& st, HashPrefix const& prefix,
PublicKey const& pk, bool mustBeFullyCanonical, PublicKey const& pk,
SF_Blob const& sigField = sfSignature); SF_Blob const& sigField = sfSignature);
/** Return a Serializer suitable for computing a multisigning TxnSignature. */ /** Return a Serializer suitable for computing a multisigning TxnSignature. */

View File

@@ -36,8 +36,7 @@ sign (STObject& st, HashPrefix const& prefix,
bool bool
verify (STObject const& st, HashPrefix const& prefix, verify (STObject const& st, HashPrefix const& prefix,
PublicKey const& pk, bool mustBeFullyCanonical, PublicKey const& pk, SF_Blob const& sigField)
SF_Blob const& sigField)
{ {
auto const sig = get(st, sigField); auto const sig = get(st, sigField);
if (! sig) if (! sig)

View File

@@ -114,11 +114,11 @@ public:
st[sfSigningPubKey] = spk; st[sfSigningPubKey] = spk;
sign(st, HashPrefix::manifest, stype, ssk); sign(st, HashPrefix::manifest, stype, ssk);
BEAST_EXPECT(verify(st, HashPrefix::manifest, spk, true)); BEAST_EXPECT(verify(st, HashPrefix::manifest, spk));
sign(st, HashPrefix::manifest, type, sk, sfMasterSignature); sign(st, HashPrefix::manifest, type, sk, sfMasterSignature);
BEAST_EXPECT(verify( BEAST_EXPECT(verify(
st, HashPrefix::manifest, pk, true, sfMasterSignature)); st, HashPrefix::manifest, pk, sfMasterSignature));
if (broken) if (broken)
{ {