Commit Graph

174 Commits

Author SHA1 Message Date
Alan Cohen
6b8cd6151d Filter insufficient source funds paths from pathfind results
When pathfinding with source amount, we need to filter out paths where source
amount is not equal to the specified source amount. This is due to the behavior
of rippled when specifying a source amount during pathfinding.

Example:

 {
  "command": "ripple_path_find",
  "source_account": "rhFQQ4ATC6MDF9ghTq3qAoCsGbGtjnhcXF",
  "destination_account": "rp91GUd5R3Rk3ipqW7XBdtrUJcX8epzGyb",
  "destination_amount": {
    "currency": "EUR",
    "issuer": "rp91GUd5R3Rk3ipqW7XBdtrUJcX8epzGyb",
    "value": -1
  },
  "send_max": {
    "currency": "USD",
    "issuer": "rhFQQ4ATC6MDF9ghTq3qAoCsGbGtjnhcXF",
    "value": "1234567891"
  },
  "id": 2
}
{
  "id": 2,
  "result": {
    "alternatives": [
      {
        "destination_amount": {
          "currency": "EUR",
          "issuer": "rp91GUd5R3Rk3ipqW7XBdtrUJcX8epzGyb",
          "value": "3999889.62127857"
        },
        "paths_canonical": [],
        "paths_computed": [
          [
            {
              "account": "rcsxQxEqU2qquAKp3tBUJy8Z2t19ioQPJ",
              "type": 1,
              "type_hex": "0000000000000001"
            },
            {
              "currency": "EUR",
              "issuer": "rp91GUd5R3Rk3ipqW7XBdtrUJcX8epzGyb",
              "type": 48,
              "type_hex": "0000000000000030"
            }
          ]
        ],
        "source_amount": {
          "currency": "USD",
          "issuer": "rhFQQ4ATC6MDF9ghTq3qAoCsGbGtjnhcXF",
          "value": "4170759.906037564"
        }
      }
    ],
    "destination_account": "rp91GUd5R3Rk3ipqW7XBdtrUJcX8epzGyb",
    "destination_amount": {
      "currency": "EUR",
      "issuer": "rp91GUd5R3Rk3ipqW7XBdtrUJcX8epzGyb",
      "value": "-1"
    },
    "destination_currencies": [
      "EUR",
      "XRP"
    ],
    "full_reply": true,
    "id": 2,
    "source_account": "rhFQQ4ATC6MDF9ghTq3qAoCsGbGtjnhcXF",
    "status": "success"
  },
  "status": "success",
  "type": "response"
}
2016-01-15 13:38:57 -08:00
Ivan Tivonenko
dc03c6e0ac fix to work in browser
run unit tests and integration tests in PhantomJS
add JUnit reporter to unit test so CircleCI can show results
2016-01-13 07:11:39 +02:00
Ivan Tivonenko
3dd21a7e11 run integration tests using standalone server 2015-12-19 02:04:05 +02:00
Chris Clark
ebfe20defb Add multisignature support 2015-12-17 11:45:08 -08:00
Chris Clark
99d08065e4 BREAKING CHANGE: Fix types of XRP values in getServerInfo response 2015-12-07 16:47:56 -08:00
Chris Clark
82613e7e8b Allow setting maxLedgerVersion to null to specify no maximum 2015-11-30 15:52:36 -08:00
Chris Clark
7061e9afe4 BREAKING CHANGE: "servers" parameter changed to single "server" and added a new broadcast wrapper class for multiple servers 2015-11-24 16:47:12 -08:00
Ivan Tivonenko
c9704137b7 fix handling memos in prepareSettings
boost coverage back to 99.88%
move connection tests to separate file
group test fixtures into namespaces
2015-11-25 02:10:54 +02:00
Ivan Tivonenko
995606b1e6 boost coverage to almost 100% 2015-11-23 17:06:55 -08:00
Chris Clark
8a3d4a64db BREAKING CHANGE: Rename "ledgerClosed" event to "ledger" and convert drops amounts to XRP 2015-11-20 11:23:19 -08:00
Chris Clark
4f90bbd931 Add resultCode and resultMessage to submit failure RippledError 2015-11-17 17:33:36 -08:00
Ivan Tivonenko
f146ea05c7 add test case for get transaction of types
suspendedPaymentExecution, suspendedPaymentCancellation, suspendedPaymentCreation
2015-11-17 23:43:01 +02:00
Chris Clark
2422b9a30b Update README for RippleAPI 2015-11-17 11:30:26 -08:00
Chris Clark
83a85a4549 Remove walletLocator and walletSize from settings 2015-11-16 13:07:25 -08:00
Chris Clark
ed8f1e4111 Support removing RegularKey 2015-11-16 10:24:02 -08:00
Chris Clark
5a8e4be9df Add descriptions to JSON schemas and organize for documentation generation 2015-11-13 15:05:53 -08:00
Chris Clark
e267e4131b Merge pull request #625 from clark800/json-schemas
Organize JSON schemas for documentation generation
2015-11-06 12:50:10 -08:00
Chris Clark
782adc6a1a Organize JSON schemas for documentation generation 2015-11-06 11:57:33 -08:00
Chris Clark
8074baa3b5 Better error message when using methods that require a connection when servers are not provided 2015-11-02 14:50:38 -08:00
Chris Clark
c7b021c7be Fix and reorganize schemas and switch to ajv validator 2015-10-30 14:28:50 -07:00
Chris Clark
2aa1695b74 Delete obsolete files and update LICENSE file 2015-10-30 14:25:33 -07:00
Chris Clark
665f5f9664 Add support for order expiration 2015-10-29 17:25:52 -07:00
Chris Clark
6c2fad508a Expose computeLedgerHash and prevent access to non-validated ledgers 2015-10-28 15:39:43 -07:00
Chris Clark
c238596a81 Emit Connection errors on RippleAPI, remove unused exports, use ripple-hashes in sign 2015-10-28 11:33:51 -07:00
Chris Clark
87dac75919 Cleanup error classes 2015-10-27 17:14:23 -07:00
Chris Clark
cd5eedff84 Rename toTimestamp/fromTimestamp 2015-10-26 17:46:57 -07:00
Chris Clark
1a99a2fddb BREAKING CHANGE: Remove dependency of src/api on src/core, removes multiserver support 2015-10-26 16:28:43 -07:00
Chris Clark
cd17d6940f BREAKING CHANGE: getFee returns promise, express fee in XRP in instructions response, use rawRequest to start decoupling Remote from API 2015-10-22 14:34:42 -07:00
Chris Clark
5aa212471c Merge pull request #606 from clark800/decouple-transaction
Decouple core.Transaction from API
2015-10-22 11:16:29 -07:00
Chris Clark
c324682ca3 Decouple core.Transaction from API 2015-10-21 11:48:40 -07:00
Matthew Fettig
aeb56dee17 rename metaData to meta on getLedger 2015-10-21 10:00:07 -07:00
Ivan Tivonenko
4faa857330 getBalances fixes:
obey limit, do not return XRP if currency or issuer specified
2015-10-16 20:46:52 +03:00
wltsmrz
772f79ae21 Update schema 2015-10-05 12:16:25 -07:00
wltsmrz
806a4e823f Add getBalanceSheet() to RippleAPI 2015-10-02 17:30:13 -07:00
Chris Clark
35acbb62c3 Support source.amount in getPaths and destination.minAmount in preparePayment 2015-10-01 14:55:11 -07:00
Ivan Tivonenko
d573c5746b refactor getLedgerVersionHelper 2015-09-30 07:07:46 +03:00
Ivan Tivonenko
51e8f9a87a make Remote.getLedgerSequence asynchronous 2015-09-30 07:05:39 +03:00
Chris Clark
5217b66396 Fix pathfind queuing and add unit test 2015-09-29 12:54:23 -07:00
Chris Clark
715c648d52 Move to new ripple-keypairs API 2015-09-23 14:30:56 -07:00
Alan Cohen
27d2e6e519 Merge pull request #557 from clark800/ledger-close
Add ledgerClosed event
2015-09-21 15:33:44 -07:00
Chris Clark
7ee368965c Add ledgerClosed event 2015-09-21 14:38:51 -07:00
Chris Clark
60c604fbe6 Merge pull request #536 from sentientwaffle/dj/suspay
suspended payments
2015-09-18 10:58:10 -07:00
sentientwaffle
b134081293 Add SuspendedPayment{Create,Finish,Cancel}
* Add SusPay core tests
* Rename SusPay -> SuspendedPayment (code review)
* Rename cancelAfter -> allowCancelAfter
* Rename suspendedPayment{Finish,Execution}
2015-09-18 10:51:34 -07:00
Alan Cohen
0c9aea454e RippleAPI: Add data property to error object 2015-09-17 16:05:43 -07:00
Alan Cohen
778f59b4fd Merge pull request #535 from clark800/submit-error
Return promise error if submit result is an immediate failure
2015-09-16 17:53:35 -07:00
Alan Cohen
60f2419b5c Add PendingLedgerVersionError
MissingLedgerHistoryError - no minLedgerVersion or maxLedgerVersion
There is a ledger gap, but a range should be provided to narrow down the range
of the gap.

MissingLedgerHistoryError
When requesting a tx, if maxLedgerVersion and minLedgerVersion provided, this
means there is a ledger gap in the provided range.

PendingLedgerVersionError:
If maxLedgerVersion provided, check if ledger is ahead of the server's last
validated ledger.
2015-09-16 15:57:55 -07:00
Chris Clark
80494ad813 Return promise error if submit result is an immediate failure 2015-09-16 15:56:24 -07:00
Alan Cohen
3c608de5bb Do not return non-validated transaction from RippleAPI#getTransaction 2015-09-16 12:19:20 -07:00
wltsmrz
c6c2dcc6c0 Merge pull request #533 from clark800/webpack-net-fix
Fix browser build
2015-09-11 13:15:58 -07:00
Chris Clark
b88e9370c6 Return instructions in prepare responses 2015-08-28 14:11:02 -07:00